Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minimal-racket 8.12 #171513

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Conversation

aryairani
Copy link

@aryairani aryairani commented May 12, 2024

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

@github-actions github-actions bot added the formula deprecated Formula deprecated label May 12, 2024
@aryairani
Copy link
Author

aryairani commented May 12, 2024

I wanted to update the deprecated dependency, but I couldn't figure out how to test the resulting formula appropriately. I guess this is no worse than what we currently have, however.

@chenrui333
Copy link
Member

build looks good. 👍

Copy link
Member

@carlocab carlocab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Feel free to mark this as ready for review when you're happy for it to merge.

@aryairani
Copy link
Author

Thanks all, I will — I'm trying to investigate some weirdness I'm seeing on my machine but then I will mark as Ready for review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
formula deprecated Formula deprecated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants