workflows/tests: enable more granular control of deps jobs #171457
Merged
+33
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, we request long timeouts for PRs whenever at least one of the formula(e) tests or dependent tests require a long timeout. This is wasteful of CI resources, because a typical PR that requires a long timeout only requires it for only one of the formula(e) tests or the dependent tests. To avoid unnecessarily congesting the long build queue, let's allow more granular control of which jobs get queued for a long build by using a separate label for dependent testing jobs that require a long timeout. I've also removed the hard-coded values for the short and long timeouts from the `check-labels.js` script so that we can keep these in `brew` instead (and now we'll only need to keep track of them in one place instead of in two).
github-actions
bot
added
workflows
carlocab
added a commit
to Homebrew/brew
that referenced
this pull request
May 11, 2024
This allows us to keep all information about timeout values here in `brew` instead of both here and in Homebrew/core. Will be needed after Homebrew/homebrew-core#171457.
carlocab
added a commit
to Homebrew/brew
that referenced
this pull request
May 11, 2024
This allows us to keep all information about timeout values here in `brew` instead of both here and in Homebrew/core. Will be needed after Homebrew/homebrew-core#171457.
carlocab
added a commit
to Homebrew/brew
that referenced
this pull request
May 11, 2024
This allows us to keep all information about timeout values here in `brew` instead of both here and in Homebrew/core. Will be needed after Homebrew/homebrew-core#171457.
7 tasks
|
Needs Homebrew/brew#17280 |
carlocab
added a commit
to Homebrew/brew
that referenced
this pull request
May 11, 2024
This allows us to keep all information about timeout values here in `brew` instead of both here and in Homebrew/core. Will be needed after Homebrew/homebrew-core#171457.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, we request long timeouts for PRs whenever at least one of the
formula(e) tests or dependent tests require a long timeout.
This is wasteful of CI resources, because a typical PR that requires a
long timeout only requires it for only one of the formula(e) tests or
the dependent tests.
To avoid unnecessarily congesting the long build queue, let's allow more
granular control of which jobs get queued for a long build by using a
separate label for dependent testing jobs that require a long timeout.
I've also removed the hard-coded values for the short and long timeouts
from the
check-labels.jsscript so that we can keep these inbrewinstead (and now we'll only need to keep track of them in one place
instead of in two).