Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

apache-arrow-glib apache-arrow 16.0.0 #169664

Merged
merged 10 commits into from Apr 25, 2024
Merged

apache-arrow-glib apache-arrow 16.0.0 #169664

merged 10 commits into from Apr 25, 2024

Conversation

chenrui333
Copy link
Member

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

@chenrui333 chenrui333 added CI-long-timeout Use longer GitHub Actions CI timeout. CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. long build Needs CI-long-timeout labels Apr 21, 2024
@github-actions github-actions bot removed the CI-long-timeout Use longer GitHub Actions CI timeout. label Apr 21, 2024
@kou kou mentioned this pull request Apr 22, 2024
Closed
@chenrui333 chenrui333 force-pushed the apache-arrow-glib-apache-arrow-16.0.0 branch from ba8419a to 9201032 Compare April 23, 2024 02:53
chenrui333 and others added 5 commits April 24, 2024 15:13
@chenrui333 @cho-m
apache-arrow-glib 16.0.0
e981910 
Signed-off-by: Rui Chen <[email protected]>
@chenrui333 @cho-m
apache-arrow 16.0.0
30fe7e3 
apache-arrow: use `llvm`

Co-authored-by: Michael Cho <[email protected]>
Signed-off-by: Michael Cho <[email protected]>
@chenrui333 @cho-m
dvc: revision bump (apache-arrow 16.0.0)
8edc5e8 
dvc: update resources

Co-authored-by: Michael Cho <[email protected]>
Signed-off-by: Michael Cho <[email protected]>
@chenrui333 @cho-m
gdal: revision bump (apache-arrow 16.0.0)
00f6c98 
Signed-off-by: Rui Chen <[email protected]>
@chenrui333 @cho-m
vineyard: revision bump (apache-arrow 16.0.0)
cc906f9 
vineyard: work around build failure with `apache-arrow` 16

Signed-off-by: Michael Cho <[email protected]>
@cho-m cho-m force-pushed the apache-arrow-glib-apache-arrow-16.0.0 branch from 9201032 to cc906f9 Compare April 24, 2024 19:15
@cho-m cho-m added CI-long-timeout Use longer GitHub Actions CI timeout. no long build conflict Do not allow merging other pull requests when files conflict with this one labels Apr 24, 2024
@github-actions github-actions bot removed the CI-long-timeout Use longer GitHub Actions CI timeout. label Apr 25, 2024
@cho-m cho-m added the ready to merge PR can be merged once CI is green label Apr 25, 2024
@cho-m
Copy link
Member

cho-m commented Apr 25, 2024 •
edited

Can look into Linux dvc failure afterward (EDIT: may be side effect of Homebrew/brew#17136):

Full linkage --test dvc output
  Missing libraries:
    libarrow_python.so

And can fix macOS mapnik linkage issue in follow up (same libunwind linking problem - Homebrew/brew#17104):

Full linkage --test mapnik output
  Broken dependencies:
    /opt/homebrew/opt/llvm@17/lib/libunwind.1.dylib (llvm@17)

cho-m
cho-m reviewed Apr 25, 2024
View reviewed changes
Formula/v/vineyard.rb
Comment on lines +56 to +59
# Work around API changes in `apache-arrow` 16+.
# Issue ref: https://github.com/v6d-io/v6d/issues/1881
arrow_uri_files = %w[modules/io/io/local_io_adaptor.cc modules/io/io/io_factory.cc]
inreplace arrow_uri_files, "arrow::internal::Uri", "arrow::util::Uri"
Copy link
Member

@cho-m cho-m Apr 25, 2024 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In a follow up PR, I will switch to upstream commit v6d-io/v6d@e8b8c82 (which was done after I reported issue v6d-io/v6d#1881 so not available at time of original run). The changes are the same, i.e. replacing all arrow::internal::Uri* usage with arrow::util::Uri*.

@github-actions GitHub Actions
Copy link
Contributor

:shipit: @cho-m has requested bottles to be published to this PR.

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Apr 25, 2024
@BrewTestBot BrewTestBot added this pull request to the merge queue Apr 25, 2024
Merged via the queue into master with commit e67e8e7 Apr 25, 2024
14 checks passed
@BrewTestBot BrewTestBot deleted the apache-arrow-glib-apache-arrow-16.0.0 branch April 25, 2024 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cho-m cho-m cho-m left review comments

@ZhongRuoyu ZhongRuoyu ZhongRuoyu approved these changes

@github-actions github-actions[bot] github-actions approved these changes

Assignees
No one assigned
Labels
CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. long build Needs CI-long-timeout no long build conflict Do not allow merging other pull requests when files conflict with this one ready to merge PR can be merged once CI is green
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@chenrui333 @cho-m @ZhongRuoyu @BrewTestBot