Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc: stop removing .brew_home #169623

Merged
merged 4 commits into from Apr 22, 2024
Merged

Conversation

branchvincent
Copy link
Member

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

Needs Homebrew/brew#17116

@github-actions github-actions bot added the go Go use is a significant feature of the PR or issue label Apr 20, 2024
@branchvincent branchvincent added the CI-no-bottles Merge without publishing bottles label Apr 21, 2024
@branchvincent
Copy link
Member Author

Don't think we need to wait for the brew change to be in a tag since this is only a cosmetic change for source builds

@branchvincent branchvincent marked this pull request as ready for review April 21, 2024 22:40
@chenrui333 chenrui333 added this pull request to the merge queue Apr 22, 2024
Merged via the queue into Homebrew:master with commit 7740ff7 Apr 22, 2024
29 checks passed
@branchvincent branchvincent deleted the brew_home branch April 22, 2024 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI-no-bottles Merge without publishing bottles go Go use is a significant feature of the PR or issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants