-
-
Notifications
You must be signed in to change notification settings - Fork 12.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
apache-arrow: switch to llvm@17 #169354
Merged
Merged
apache-arrow: switch to llvm@17 #169354
Changes from 11 commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
9ad4cd9
apache-arrow: switch to llvm@17
carlocab d2c8045
apache-arrow-glib: remove LLVM from library search paths
ZhongRuoyu e856794
gdal: remove LLVM from library search paths
ZhongRuoyu 58064cd
mapnik: remove LLVM from library search paths
ZhongRuoyu 325382a
mapserver: remove LLVM from library search paths
ZhongRuoyu b8ee135
osm2pgrouting: remove LLVM from library search paths
ZhongRuoyu 5fa0fd1
osmcoastline: remove LLVM from library search paths
ZhongRuoyu 59f323c
pgrouting: remove LLVM from library search paths
ZhongRuoyu 1f3a860
postgis: remove LLVM from library search paths
ZhongRuoyu 3e885df
rtabmap: remove LLVM from library search paths
ZhongRuoyu a586036
spatialite-gui: remove LLVM from library search paths
ZhongRuoyu ff14d96
apache-arrow: update 15.0.2_2 bottle.
ZhongRuoyu e4f1363
apache-arrow-glib: update 15.0.2_1 bottle.
ZhongRuoyu 06590a1
gdal: update 3.8.5_1 bottle.
ZhongRuoyu 9f8ff5e
mapnik: update 3.1.0_27 bottle.
ZhongRuoyu 33daa81
mapserver: update 8.0.1_4 bottle.
ZhongRuoyu c84e4c1
osm2pgrouting: update 2.3.8_12 bottle.
ZhongRuoyu 0440e52
osmcoastline: update 2.4.0_5 bottle.
ZhongRuoyu 3342e50
pgrouting: update 3.6.2_1 bottle.
ZhongRuoyu c297b28
postgis: update 3.4.2_1 bottle.
ZhongRuoyu 811900f
rtabmap: update 0.21.4_2 bottle.
ZhongRuoyu 832caa8
spatialite-gui: update 2.1.0-beta1_5 bottle.
ZhongRuoyu File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should probably just handle this in
brew
at this point.Though, dare I ask -- why don't we want linkage with our
libunwind
? As long as they're all using the same one it should be ok... (Though admittedly guaranteeing that may be a tall order)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yea, I agree. Was looking into this too.
Because we cannot be sure the LLVM used to build the formula (or simply present at build time) will continue to stay around until the next rebuild/update -- unless it's a direct runtime dependency.
Some formulae have a build-only dependency on
llvm
. The linkage test would have failed should there be libunwind linkage. This was the case when this workaround was added toapache-arrow
in #146072 though LLVM became a runtime dependency later.Some others, like the dependents here, depend on
llvm
indirectly via another runtime dependency (apache-arrow
in this case). This makes it unnecessarily challenging for us to switch the dependency formula to a differentllvm
. Even a "hello world" can link to libunwind unexpectedly.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense.
In current state, dependents are mixing libs and can end up crashing, e.g. #161342 (as I recall, there should be a couple other crashes fixed by unlinking
llvm
's libunwind)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Homebrew/brew#17104
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is really weird. Smells like a bug in
ld
to me. Thoughts, @Bo98?