Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

workflows: use artifact v4 for event_payload #167347

Merged
merged 1 commit into from Mar 28, 2024
Merged

workflows: use artifact v4 for event_payload #167347

merged 1 commit into from Mar 28, 2024

Conversation

Bo98
Copy link
Member

@Bo98 Bo98 commented Mar 28, 2024 •
edited

The two challenges here:

  • How to actually test this (probably can't)
  • By design, v3 and v4 artifacts cannot be mixed. So these workflows may temporarily break for existing PRs, which can be fixed either by rerunning the triage workflow or by just accepting this and doing brew pr-publish merges instead for the current set.

@Bo98 Bo98 requested review from MikeMcQuaid and a team as code owners March 28, 2024 00:24
@github-actions github-actions bot added workflows PR modifies GitHub Actions workflow files automerge-skip `brew pr-automerge` will skip this pull request labels Mar 28, 2024
@chenrui333 chenrui333 added this pull request to the merge queue Mar 28, 2024
Merged via the queue into master with commit 96bcafd Mar 28, 2024
19 checks passed
@chenrui333 chenrui333 deleted the event_payload-v4 branch March 28, 2024 16:31
@Bo98 Bo98 mentioned this pull request Mar 29, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MikeMcQuaid MikeMcQuaid MikeMcQuaid approved these changes

@chenrui333 chenrui333 chenrui333 approved these changes

@carlocab carlocab carlocab approved these changes

Assignees
No one assigned
Labels
automerge-skip `brew pr-automerge` will skip this pull request workflows PR modifies GitHub Actions workflow files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Bo98 @MikeMcQuaid @chenrui333 @carlocab