workflows/autobump: stop running on unrelated workflow updates #167020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
workflows
ZhongRuoyu
approved these changes
Mar 24, 2024
SMillerDev
previously requested changes
Mar 24, 2024
Do you mean running on modifications of |
|
Yeah, otherwise it'll take a while before we figure out we broke it |
|
Okay. Should be fine to run on those as we aren't modifying this workflow that often after splitting out the bump list into a separate file. |
The original reason for this in #129465 was for @BrewTestBot's fork but I don't think this behavior is needed our current workflows. We may need to reconsider if we change the approach in future. Fixes #164661 Signed-off-by: Michael Cho <[email protected]>
cho-m
force-pushed
the
autobump-not-on-push
branch
from
590a354
to
acf6ca8
Compare
cho-m
changed the title
MikeMcQuaid
approved these changes
Mar 24, 2024
|
Thanks again @cho-m! |
SMillerDev
approved these changes
Mar 25, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original reason for this in #129465 was for @BrewTestBot's fork but I don't think this behavior is needed our current workflows. We may need to reconsider if we change the approach in future.
Fixes #164661
HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where<formula>is the name of the formula you're submitting?brew test <formula>, where<formula>is the name of the formula you're submitting?brew audit --strict <formula>(after doingHOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it passbrew audit --new <formula>?