Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

srgn 0.11.0 (new formula) #165653

Merged
merged 2 commits into from Mar 11, 2024
Merged

srgn 0.11.0 (new formula) #165653

merged 2 commits into from Mar 11, 2024

Conversation

chenrui333
Copy link
Member

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

Signed-off-by: Rui Chen <[email protected]>

autobump: add srgn

Signed-off-by: Rui Chen <[email protected]>
@github-actions github-actions bot added the automerge-skip `brew pr-automerge` will skip this pull request label Mar 10, 2024
@chenrui333 chenrui333 added autobump and removed automerge-skip `brew pr-automerge` will skip this pull request labels Mar 10, 2024
@@ -1572,6 +1572,7 @@ squealer
squid
sratoolkit
src
srgn
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Homebrew/core do we want to automatically add all software to this list? Maybe we should make a blocklist instead then.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't it be better to store this information in the formula itself?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you mean autobump info?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dont think we have a way of doing it now atm

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No we don't, but it would seem to be 1. a more relevant place to put it, 2. more scalable (no merge conflicts, no tedious long list of formulas). Should we propose it?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds like something we should consider.

Maybe also have an option to specify if bumped by upstream as we removed those formulae in #164770 but we don't have a way to keep track of them. This can lead to us accidentally re-adding them and potentially messing up the upstream release flow. Otherwise, we would probably need another list to record this info to avoid having maintainers manually keep track of it.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should only really make this a formula DSL if we're going to make it possible for third-party taps to use autobump somehow too.

We shouldn't add software automatically here but it does seem reasonable to add it manually.

@chenrui333 chenrui333 added the ready to merge PR can be merged once CI is green label Mar 11, 2024
Copy link
Contributor

🤖 An automated task has requested bottles to be published to this PR.

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Mar 11, 2024
@BrewTestBot BrewTestBot added this pull request to the merge queue Mar 11, 2024
Merged via the queue into master with commit b54c33d Mar 11, 2024
13 checks passed
@BrewTestBot BrewTestBot deleted the srgn branch March 11, 2024 15:49
@chenrui333 chenrui333 added the new formula PR adds a new formula to Homebrew/homebrew-core label Mar 11, 2024
@github-actions github-actions bot added the outdated PR was locked due to age label Apr 11, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
autobump CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. new formula PR adds a new formula to Homebrew/homebrew-core outdated PR was locked due to age ready to merge PR can be merged once CI is green
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants