Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workflows/triage: CI-build-dependents-from-source changes #165416

Merged
merged 1 commit into from Mar 25, 2024

Conversation

cho-m
Copy link
Member

@cho-m cho-m commented Mar 7, 2024

  • Only label ghc and go formulae on major/minor version bumps by checking when the alias changes. This may break if we no longer need the alias, but it avoids having to introduce version parsing.
  • Ignore labeling formulae when only revision bumped or even situations where formula has an existing revision (as most cases we want to test on version bumps and those will always remove/reset the revision). One situation this doesn't help is non-bump PRs on a formula that has no revision stanza.
  • Set allow_any_match to label PRs when Alias and Formula need to be modified or when other revision bumps are needed.
  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

@github-actions github-actions bot added automerge-skip `brew pr-automerge` will skip this pull request workflows PR modifies GitHub Actions workflow files labels Mar 7, 2024
@cho-m
Copy link
Member Author

cho-m commented Mar 7, 2024

May need to test afterward examples like:

Formula Test Expected Result
ghc revision bump No label ✅︎
ghc patch version bump No label ✅︎
ghc major/minor version bump Label ✅︎
rust revision bump No label
rust patch version bump Label

@cho-m cho-m force-pushed the triage-CI-build-dependents-from-source branch 3 times, most recently from 41f77a6 to b8eb9e5 Compare March 8, 2024 03:48
@cho-m cho-m force-pushed the triage-CI-build-dependents-from-source branch from b8eb9e5 to df69edb Compare March 23, 2024 17:24
@github-actions github-actions bot added the long build Needs CI-long-timeout label Mar 23, 2024
@cho-m cho-m force-pushed the triage-CI-build-dependents-from-source branch from 154ceec to df69edb Compare March 23, 2024 17:33
@cho-m cho-m removed the long build Needs CI-long-timeout label Mar 23, 2024
@cho-m cho-m marked this pull request as ready for review March 23, 2024 17:34
@cho-m cho-m requested review from MikeMcQuaid and a team as code owners March 23, 2024 17:34
* Only label `ghc` and `go` formulae on major/minor version bumps by
  checking when the alias changes. This may break if we no longer need
  the alias, but it avoids having to introduce version parsing.
* Ignore labeling formulae when only revision bumped or even situations
  where formula has an existing revision (as most cases we want to test
  on version bumps and those will always remove/reset the revision).
  One situation this doesn't help is non-bump PRs on a formula that has
  no revision stanza.
* Set `allow_any_match` to label PRs when Alias and Formula need to be
  modified or when other revision bumps are needed.

Signed-off-by: Michael Cho <[email protected]>
@cho-m cho-m force-pushed the triage-CI-build-dependents-from-source branch from df69edb to 7729899 Compare March 23, 2024 17:46
@cho-m cho-m added the ready to merge PR can be merged once CI is green label Mar 24, 2024
@MikeMcQuaid
Copy link
Member

Thanks @cho-m!

@cho-m
Copy link
Member Author

cho-m commented Mar 25, 2024

Going to give this a try. Will follow up if it isn't behaving as expected.

@cho-m cho-m added this pull request to the merge queue Mar 25, 2024
@cho-m cho-m removed the automerge-skip `brew pr-automerge` will skip this pull request label Mar 25, 2024
Merged via the queue into Homebrew:master with commit dc1d05a Mar 25, 2024
20 checks passed
@cho-m cho-m deleted the triage-CI-build-dependents-from-source branch March 25, 2024 12:10
Copy link
Contributor

🤖 An automated task has requested bottles to be published to this PR.

Copy link
Contributor

⚠️ Bottle publish failed.

@github-actions github-actions bot added the outdated PR was locked due to age label Apr 24, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age ready to merge PR can be merged once CI is green workflows PR modifies GitHub Actions workflow files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants