Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

glfw: provide a static library #165411

Merged
merged 2 commits into from Mar 18, 2024

Conversation

laytan
Copy link
Contributor

@laytan laytan commented Mar 7, 2024

During #164071 it came up to provide a static library for glfw, see #164071 (comment).

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

During Homebrew#164071 it came up to provide a static library for glfw, see
Homebrew#164071 (comment).
@fxcoudert
Copy link
Member

fxcoudert commented Mar 7, 2024

The idea in #164071 was to use to in odin, can you please check it works? That would remove a resource there.

@laytan
Copy link
Contributor Author

laytan commented Mar 7, 2024

The idea in #164071 was to use to in odin, can you please check it works? That would remove a resource there.

Sorry, what?

@fxcoudert
Copy link
Member

You said:

For glfw brew just installs a dynamic library, not a static one, so that won't work in its current state

I'm not sure why odin would not build with a dynamic library, but that statement was the reason for suggesting adding a static library.

@laytan
Copy link
Contributor Author

laytan commented Mar 7, 2024

You said:

For glfw brew just installs a dynamic library, not a static one, so that won't work in its current state

I'm not sure why odin would not build with a dynamic library, but that statement was the reason for suggesting adding a static library.

Odin provides an option for both (for users of Odin, it is not required for Odin the compiler, but for the "std" library), but prefers static because it is objectively better.

Even without thinking of the Odin PR, having a static library available is a good thing in general.

@MikeMcQuaid
Copy link
Member

Thanks so much for your first contribution! Without people like you submitting PRs we couldn't run this project. You rock, @laytan!

Copy link
Contributor

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Mar 18, 2024
@BrewTestBot BrewTestBot added this pull request to the merge queue Mar 18, 2024
Merged via the queue into Homebrew:master with commit 806fa30 Mar 18, 2024
13 checks passed
@laytan laytan deleted the glfw-provide-static-lib branch March 18, 2024 19:40
@github-actions github-actions bot added the outdated PR was locked due to age label Apr 18, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants