Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workflows/triage: remove bottle unneeded label #165371

Merged
merged 1 commit into from Mar 7, 2024

Conversation

cho-m
Copy link
Member

@cho-m cho-m commented Mar 7, 2024

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

We no longer support this in homebrew-core.

May need to check if we have an audit for this in core tap.

@cho-m cho-m requested review from MikeMcQuaid and a team as code owners March 7, 2024 15:10
@github-actions github-actions bot added workflows PR modifies GitHub Actions workflow files automerge-skip `brew pr-automerge` will skip this pull request labels Mar 7, 2024
@Bo98
Copy link
Member

Bo98 commented Mar 7, 2024

May need to check if we have an audit for this in core tap.

Support for it was removed entirely in brew for all taps

@chenrui333 chenrui333 added this pull request to the merge queue Mar 7, 2024
Merged via the queue into master with commit 77ae0c3 Mar 7, 2024
18 checks passed
@chenrui333 chenrui333 deleted the triage-remove-bottle-unneeded branch March 7, 2024 17:34
@github-actions github-actions bot added the outdated PR was locked due to age label Apr 7, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
automerge-skip `brew pr-automerge` will skip this pull request outdated PR was locked due to age workflows PR modifies GitHub Actions workflow files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants