Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[email protected], [email protected]: fix type issues #142865

Merged
merged 2 commits into from
Sep 15, 2023

Conversation

samford
Copy link
Member

@samford samford commented Sep 15, 2023

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

This is a follow-up to the recent PRs to fix Sorbet type issues (#142299, #142336, #142344, #142357), as I missed these two formulae. This will address the [email protected] error in #142161 (comment) (and preemptively avoid a [email protected] error).

@samford samford added CI-skip-recursive-dependents Pass --skip-recursive-dependents to brew test-bot. CI-skip-dependents Pass --skip-dependents to brew test-bot. CI-no-bottles Merge without publishing bottles labels Sep 15, 2023
@github-actions GitHub Actions bot added the legacy Relates to a versioned @ formula label Sep 15, 2023
@samford samford added this pull request to the merge queue Sep 15, 2023
Merged via the queue into Homebrew:master with commit e65e364 Sep 15, 2023
20 checks passed
@samford samford deleted the nil-env-fixes/versioned-lua branch September 15, 2023 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI-no-bottles Merge without publishing bottles CI-skip-dependents Pass --skip-dependents to brew test-bot. CI-skip-recursive-dependents Pass --skip-recursive-dependents to brew test-bot. legacy Relates to a versioned @ formula sonoma-bottling
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants