lando 2.3.2 new formula alias old lando-cli #196159
Open
+34
−41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a `lando` formula to build the canonical lando source from `lando/core`. Aliased old formula `lando-cli`; note that the `lando/cli` repo will stop receiving updates as it has now been integrated into `lando/core` as of https://github.com/lando/core/releases/tag/v3.23.0.
github-actions
bot
added
automerge-skip
|
Thanks for contributing to Homebrew! 🎉 It looks like you're having trouble with a CI failure. See our contribution guide for help. You may be most interested in the section on dealing with CI failures. You can find the CI logs in the Checks tab of your pull request. |
|
Please don't add merge commits, they break CI |
SMillerDev
reviewed
Oct 31, 2024
|
|
||
| def caveats | ||
| <<~EOS | ||
| To complete the installation: |
There was a problem hiding this comment.
Is this specific to homebrew? Otherwise it should not be a caveat
|
|
||
| def install | ||
| system "npm", "install", "--production", *std_npm_args | ||
| system "npm", "add", "@yao-pkg/[email protected]" |
There was a problem hiding this comment.
It shouldn't download unchecksummed things as part of the build
| def install | ||
| system "npm", "install", "--production", *std_npm_args | ||
| system "npm", "add", "@yao-pkg/[email protected]" | ||
| system "npx", "pkg", "--config", "package.json", "--targets", "node20", |
There was a problem hiding this comment.
The more formula is not node 20
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a new
landoformula to build Lando from source, removes the existinglando-cliformula, and aliaseslando-clitolando.Noticed that a
lando-cliformula got into brew, which is great! But...the Lando project is folding that repo (https://github.com/lando/cli) into lando/core, so releases won't be available there going forward from v3.23 (see https://github.com/lando/core/releases/tag/v3.23.0).Let me know if I didn't do something right on the PR, first shot :)
BTW, I noticed
brew audit --new landofails on the requisite watch/fork numbers, sincelando/coreisn't the main "watched" repo for Lando...lando/landois representative of the project's popularity.HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where<formula>is the name of the formula you're submitting?brew test <formula>, where<formula>is the name of the formula you're submitting?brew audit --strict <formula>(after doingHOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it passbrew audit --new <formula>?