Merge pull request #179164 from Homebrew/p-rubocop-no-rmrf

p*: Fix `Homebrew/NoFileutilsRmrf` RuboCop offenses

Formula/p/packetbeat.rb

@@ -25,7 +25,7 @@ class Packetbeat < Formula
 
  def install
  # remove non open source files
- rm_rf "x-pack"
+ rm_r("x-pack")
 
  cd "packetbeat" do
  # prevent downloading binary wheels during python setup

Formula/p/pacmc.rb

@@ -12,7 +12,7 @@ class Pacmc < Formula
  depends_on "openjdk"
 
  def install
- rm_f Dir["bin/*.bat"]
+ rm(Dir["bin/*.bat"])
  libexec.install %w[bin lib]
  (bin/"pacmc").write_env_script libexec/"bin/pacmc", Language::Java.overridable_java_home_env
  end

Formula/p/pandoc-crossref.rb

@@ -24,7 +24,7 @@ class PandocCrossref < Formula
  uses_from_macos "zlib"
 
  def install
- rm_f "cabal.project.freeze"
+ rm("cabal.project.freeze")
 
  system "cabal", "v2-update"
  system "cabal", "v2-install", *std_cabal_v2_args

Formula/p/parrot.rb

@@ -57,7 +57,7 @@ def install
  system "make"
  system "make", "install"
  # Don't install this file in HOMEBREW_PREFIX/lib
- rm_rf lib/"VERSION"
+ rm_r(lib/"VERSION")
  end
 
  test do

Formula/p/passenger.rb

@@ -59,9 +59,9 @@ def install
  (libexec/"download_cache").mkpath
 
  # Fixes https://github.com/phusion/passenger/issues/1288
- rm_rf "buildout/libev"
- rm_rf "buildout/libuv"
- rm_rf "buildout/cache"
+ rm_r("buildout/libev")
+ rm_r("buildout/libuv")
+ rm_r("buildout/cache")
 
  necessary_files = %w[configure Rakefile README.md CONTRIBUTORS
  CONTRIBUTING.md LICENSE CHANGELOG package.json

Formula/p/pax-construct.rb

@@ -17,7 +17,7 @@ class PaxConstruct < Formula
  depends_on "maven"
 
  def install
- rm_rf Dir["bin/*.bat"]
+ rm_r(Dir["bin/*.bat"])
  prefix.install_metafiles "bin" # Don't put these in bin!
  libexec.install Dir["*"]
  bin.write_exec_script Dir["#{libexec}/bin/*"].select { |f| File.executable? f }

Formula/p/payara.rb

@@ -24,7 +24,7 @@ class Payara < Formula
 
  def install
  # Remove Windows scripts
- rm_f Dir["**/*.{bat,exe}"]
+ rm(Dir["**/*.{bat,exe}"])
 
  inreplace "bin/asadmin", /AS_INSTALL=.*/,
  "AS_INSTALL=#{libexec}/glassfish"

Formula/p/pdal.rb

@@ -78,7 +78,7 @@ def install
  system "cmake", "--build", "build"
  system "cmake", "--install", "build"
 
- rm_rf "test/unit"
+ rm_r("test/unit")
  doc.install "examples", "test"
  end
 

Formula/p/percona-server.rb

@@ -147,11 +147,11 @@ def install
  end
 
  # Remove the tests directory
- rm_rf prefix/"mysql-test"
+ rm_r(prefix/"mysql-test")
 
  # Don't create databases inside of the prefix!
  # See: https://github.com/Homebrew/homebrew/issues/4975
- rm_rf prefix/"data"
+ rm_r(prefix/"data")
 
  # Fix up the control script and link into bin.
  inreplace "#{prefix}/support-files/mysql.server",

Formula/p/perkeep.rb

@@ -48,7 +48,7 @@ def install
 
  # Vendored version of gopherjs requires go 1.10, so use the newest available gopherjs, which
  # supports newer Go versions.
- rm_rf buildpath/"src/perkeep.org/vendor/github.com/gopherjs/gopherjs"
+ rm_r(buildpath/"src/perkeep.org/vendor/github.com/gopherjs/gopherjs")
  resource("gopherjs").stage buildpath/"src/perkeep.org/vendor/github.com/gopherjs/gopherjs"
 
  cd "src/perkeep.org" do

Formula/p/petsc-complex.rb

@@ -51,7 +51,7 @@ def install
  system "make", "install"
 
  # Avoid references to Homebrew shims
- rm_f lib/"petsc/conf/configure-hash"
+ rm(lib/"petsc/conf/configure-hash")
 
  if OS.mac? || File.foreach("#{lib}/petsc/conf/petscvariables").any? { |l| l[Superenv.shims_path.to_s] }
  inreplace lib/"petsc/conf/petscvariables", "#{Superenv.shims_path}/", ""

Formula/p/petsc.rb

@@ -52,7 +52,7 @@ def install
  system "make", "install"
 
  # Avoid references to Homebrew shims
- rm_f lib/"petsc/conf/configure-hash"
+ rm(lib/"petsc/conf/configure-hash")
 
  if OS.mac? || File.foreach("#{lib}/petsc/conf/petscvariables").any? { |l| l[Superenv.shims_path.to_s] }
  inreplace lib/"petsc/conf/petscvariables", "#{Superenv.shims_path}/", ""

Formula/p/phoronix-test-suite.rb

@@ -33,7 +33,7 @@ def install
 
  # 7.4.0 installed files in the formula's rack so clean up the mess.
  def post_install
- rm_rf [prefix/"../etc", prefix/"../usr"]
+ rm_r([prefix/"../etc", prefix/"../usr"])
  end
 
  test do

Formula/p/ppsspp.rb

@@ -50,10 +50,10 @@ def install
  # See https://github.com/Homebrew/homebrew-core/issues/84737.
  cd "ffmpeg" do
  if OS.mac?
- rm_rf "macosx"
+ rm_r("macosx")
  system "./mac-build.sh"
  else
- rm_rf "linux"
+ rm_r("linux")
  system "./linux_x86-64.sh"
  end
  end

Formula/p/pypy.rb

@@ -135,9 +135,9 @@ def post_install
  # Symlink the prefix site-packages into the cellar.
  unless (libexec/"site-packages").symlink?
  # fix the case where libexec/site-packages/site-packages was installed
- rm_rf libexec/"site-packages/site-packages"
+ rm_r(libexec/"site-packages/site-packages")
  mv Dir[libexec/"site-packages/*"], prefix_site_packages
- rm_rf libexec/"site-packages"
+ rm_r(libexec/"site-packages")
  end
  libexec.install_symlink prefix_site_packages
 

Formula/p/pypy3.10.rb

@@ -130,7 +130,7 @@ def install
 
  # Delete two files shipped which we do not want to deliver
  # These files make patchelf fail
- rm_f [libexec/"bin/libpypy#{abi_version}-c.so.debug", libexec/"bin/pypy#{abi_version}.debug"]
+ rm([libexec/"bin/libpypy#{abi_version}-c.so.debug", libexec/"bin/pypy#{abi_version}.debug"])
  end
 
  def post_install
@@ -147,7 +147,7 @@ def post_install
  # Create a site-packages in the prefix.
  site_packages(HOMEBREW_PREFIX).mkpath
  touch site_packages(HOMEBREW_PREFIX)/".keepme"
- site_packages(libexec).rmtree
+ rm_r(site_packages(libexec))
 
  # Symlink the prefix site-packages into the cellar.
  site_packages(libexec).parent.install_symlink site_packages(HOMEBREW_PREFIX)

Formula/p/pypy3.9.rb

@@ -137,7 +137,7 @@ def post_install
  # Create a site-packages in the prefix.
  site_packages(HOMEBREW_PREFIX).mkpath
  touch site_packages(HOMEBREW_PREFIX)/".keepme"
- site_packages(libexec).rmtree
+ rm_r(site_packages(libexec))
 
  # Symlink the prefix site-packages into the cellar.
  site_packages(libexec).parent.install_symlink site_packages(HOMEBREW_PREFIX)

Formula/p/python@3.10.rb

@@ -273,7 +273,7 @@ def install
  end
 
  # Remove the site-packages that Python created in its Cellar.
- site_packages_cellar.rmtree
+ rm_r(site_packages_cellar)
 
  # Prepare a wheel of wheel to install later.
  common_pip_args = %w[
@@ -343,16 +343,16 @@ def post_install
  site_packages_cellar.parent.install_symlink site_packages
 
  # Remove old sitecustomize.py. Now stored in the cellar.
- rm_rf Dir["#{site_packages}/sitecustomize.py[co]"]
+ rm_r(Dir["#{site_packages}/sitecustomize.py[co]"])
 
  # Remove old setuptools installations that may still fly around and be
  # listed in the easy_install.pth. This can break setuptools build with
  # zipimport.ZipImportError: bad local file header
  # setuptools-0.9.8-py3.3.egg
- rm_rf Dir["#{site_packages}/setuptools[-_.][0-9]*", "#{site_packages}/setuptools"]
- rm_rf Dir["#{site_packages}/distribute[-_.][0-9]*", "#{site_packages}/distribute"]
- rm_rf Dir["#{site_packages}/pip[-_.][0-9]*", "#{site_packages}/pip"]
- rm_rf Dir["#{site_packages}/wheel[-_.][0-9]*", "#{site_packages}/wheel"]
+ rm_r(Dir["#{site_packages}/setuptools[-_.][0-9]*", "#{site_packages}/setuptools"])
+ rm_r(Dir["#{site_packages}/distribute[-_.][0-9]*", "#{site_packages}/distribute"])
+ rm_r(Dir["#{site_packages}/pip[-_.][0-9]*", "#{site_packages}/pip"])
+ rm_r(Dir["#{site_packages}/wheel[-_.][0-9]*", "#{site_packages}/wheel"])
 
  system python3, "-Im", "ensurepip"
 
@@ -377,7 +377,7 @@ def post_install
  mv (site_packages/"bin").children, bin
  rmdir site_packages/"bin"
 
- rm_rf bin.glob("pip{,3}")
+ rm_r(bin.glob("pip{,3}"))
  mv bin/"wheel", bin/"wheel#{version.major_minor}"
 
  # Install unversioned and major-versioned symlinks in libexec/bin.

Formula/p/python@3.11.rb

@@ -276,7 +276,7 @@ def install
  end
 
  # Remove the site-packages that Python created in its Cellar.
- site_packages_cellar.rmtree
+ rm_r(site_packages_cellar)
 
  # Prepare a wheel of wheel to install later.
  common_pip_args = %w[
@@ -346,16 +346,16 @@ def post_install
  site_packages_cellar.parent.install_symlink site_packages
 
  # Remove old sitecustomize.py. Now stored in the cellar.
- rm_rf Dir["#{site_packages}/sitecustomize.py[co]"]
+ rm_r(Dir["#{site_packages}/sitecustomize.py[co]"])
 
  # Remove old setuptools installations that may still fly around and be
  # listed in the easy_install.pth. This can break setuptools build with
  # zipimport.ZipImportError: bad local file header
  # setuptools-0.9.8-py3.3.egg
- rm_rf Dir["#{site_packages}/setuptools[-_.][0-9]*", "#{site_packages}/setuptools"]
- rm_rf Dir["#{site_packages}/distribute[-_.][0-9]*", "#{site_packages}/distribute"]
- rm_rf Dir["#{site_packages}/pip[-_.][0-9]*", "#{site_packages}/pip"]
- rm_rf Dir["#{site_packages}/wheel[-_.][0-9]*", "#{site_packages}/wheel"]
+ rm_r(Dir["#{site_packages}/setuptools[-_.][0-9]*", "#{site_packages}/setuptools"])
+ rm_r(Dir["#{site_packages}/distribute[-_.][0-9]*", "#{site_packages}/distribute"])
+ rm_r(Dir["#{site_packages}/pip[-_.][0-9]*", "#{site_packages}/pip"])
+ rm_r(Dir["#{site_packages}/wheel[-_.][0-9]*", "#{site_packages}/wheel"])
 
  system python3, "-Im", "ensurepip"
 
@@ -380,7 +380,7 @@ def post_install
  mv (site_packages/"bin").children, bin
  rmdir site_packages/"bin"
 
- rm_rf bin.glob("pip{,3}")
+ rm_r(bin.glob("pip{,3}"))
  mv bin/"wheel", bin/"wheel#{version.major_minor}"
 
  # Install unversioned and major-versioned symlinks in libexec/bin.

Formula/p/python@3.12.rb

@@ -268,7 +268,7 @@ def install
  end
 
  # Remove the site-packages that Python created in its Cellar.
- site_packages_cellar.rmtree
+ rm_r(site_packages_cellar)
 
  # Prepare a wheel of wheel to install later.
  common_pip_args = %w[
@@ -334,15 +334,15 @@ def post_install
  site_packages_cellar.parent.install_symlink site_packages
 
  # Remove old sitecustomize.py. Now stored in the cellar.
- rm_rf Dir["#{site_packages}/sitecustomize.py[co]"]
+ rm_r(Dir["#{site_packages}/sitecustomize.py[co]"])
 
  # Remove old setuptools installations that may still fly around and be
  # listed in the easy_install.pth. This can break setuptools build with
  # zipimport.ZipImportError: bad local file header
  # setuptools-0.9.8-py3.3.egg
- rm_rf Dir["#{site_packages}/distribute[-_.][0-9]*", "#{site_packages}/distribute"]
- rm_rf Dir["#{site_packages}/pip[-_.][0-9]*", "#{site_packages}/pip"]
- rm_rf Dir["#{site_packages}/wheel[-_.][0-9]*", "#{site_packages}/wheel"]
+ rm_r(Dir["#{site_packages}/distribute[-_.][0-9]*", "#{site_packages}/distribute"])
+ rm_r(Dir["#{site_packages}/pip[-_.][0-9]*", "#{site_packages}/pip"])
+ rm_r(Dir["#{site_packages}/wheel[-_.][0-9]*", "#{site_packages}/wheel"])
 
  (lib_cellar/"EXTERNALLY-MANAGED").unlink if (lib_cellar/"EXTERNALLY-MANAGED").exist?
  system python3, "-Im", "ensurepip"
@@ -367,7 +367,7 @@ def post_install
  mv (site_packages/"bin").children, bin
  rmdir site_packages/"bin"
 
- rm_rf bin/"pip"
+ rm_r(bin/"pip")
  mv bin/"wheel", bin/"wheel#{version.major_minor}"
  bin.install_symlink "wheel#{version.major_minor}" => "wheel3"
 

Formula/p/python@3.8.rb

@@ -245,7 +245,7 @@ def install
  end
 
  # Remove the site-packages that Python created in its Cellar.
- site_packages_cellar.rmtree
+ rm_r(site_packages_cellar)
 
  %w[setuptools pip wheel].each do |r|
  (libexec/r).install resource(r)
@@ -284,16 +284,16 @@ def post_install
  site_packages_cellar.parent.install_symlink site_packages
 
  # Write our sitecustomize.py
- rm_rf site_packages.glob("sitecustomize.py[co]")
+ rm_r(site_packages.glob("sitecustomize.py[co]"))
  (site_packages/"sitecustomize.py").atomic_write(sitecustomize)
 
  # Remove old setuptools installations that may still fly around and be
  # listed in the easy_install.pth. This can break setuptools build with
  # zipimport.ZipImportError: bad local file header
  # setuptools-0.9.8-py3.3.egg
- rm_rf Dir["#{site_packages}/setuptools*"]
- rm_rf Dir["#{site_packages}/distribute*"]
- rm_rf Dir["#{site_packages}/pip[-_.][0-9]*", "#{site_packages}/pip"]
+ rm_r(Dir["#{site_packages}/setuptools*"])
+ rm_r(Dir["#{site_packages}/distribute*"])
+ rm_r(Dir["#{site_packages}/pip[-_.][0-9]*", "#{site_packages}/pip"])
 
  %w[setuptools pip wheel].each do |pkg|
  (libexec/pkg).cd do
@@ -305,7 +305,7 @@ def post_install
  end
  end
 
- rm_rf bin.glob("{easy_install,pip{,3}}")
+ rm_r(bin.glob("{easy_install,pip{,3}}"))
  mv bin/"wheel", bin/"wheel#{version.major_minor}"
 
  # Install unversioned and major-versioned symlinks in libexec/bin.

Formula/p/python@3.9.rb

@@ -258,7 +258,7 @@ def install
  end
 
  # Remove the site-packages that Python created in its Cellar.
- site_packages_cellar.rmtree
+ rm_r(site_packages_cellar)
 
  # Prepare a wheel of wheel to install later.
  common_pip_args = %w[
@@ -329,16 +329,16 @@ def post_install
  site_packages_cellar.parent.install_symlink site_packages
 
  # Remove old sitecustomize.py. Now stored in the cellar.
- rm_rf Dir["#{site_packages}/sitecustomize.py[co]"]
+ rm_r(Dir["#{site_packages}/sitecustomize.py[co]"])
 
  # Remove old setuptools installations that may still fly around and be
  # listed in the easy_install.pth. This can break setuptools build with
  # zipimport.ZipImportError: bad local file header
  # setuptools-0.9.8-py3.3.egg
- rm_rf Dir["#{site_packages}/setuptools[-_.][0-9]*", "#{site_packages}/setuptools"]
- rm_rf Dir["#{site_packages}/distribute[-_.][0-9]*", "#{site_packages}/distribute"]
- rm_rf Dir["#{site_packages}/pip[-_.][0-9]*", "#{site_packages}/pip"]
- rm_rf Dir["#{site_packages}/wheel[-_.][0-9]*", "#{site_packages}/wheel"]
+ rm_r(Dir["#{site_packages}/setuptools[-_.][0-9]*", "#{site_packages}/setuptools"])
+ rm_r(Dir["#{site_packages}/distribute[-_.][0-9]*", "#{site_packages}/distribute"])
+ rm_r(Dir["#{site_packages}/pip[-_.][0-9]*", "#{site_packages}/pip"])
+ rm_r(Dir["#{site_packages}/wheel[-_.][0-9]*", "#{site_packages}/wheel"])
 
  system python3, "-Im", "ensurepip"
 
@@ -363,7 +363,7 @@ def post_install
  mv (site_packages/"bin").children, bin
  rmdir site_packages/"bin"
 
- rm_rf bin.glob("pip{,3}")
+ rm_r(bin.glob("pip{,3}"))
  mv bin/"wheel", bin/"wheel#{version.major_minor}"
 
  # Install unversioned and major-versioned symlinks in libexec/bin.

Formula/p/pythran.rb

@@ -68,7 +68,7 @@ def dprod(arr0, arr1):
  return sum([x*y for x,y in zip(arr0, arr1)])
  EOS
  system pythran, testpath/"dprod.py"
- rm_f testpath/"dprod.py"
+ rm(testpath/"dprod.py")
 
  assert_equal "11", shell_output("#{python3} -c 'import dprod; print(dprod.dprod([1,2], [3,4]))'").chomp
 
@@ -87,7 +87,7 @@ def arc_distance(theta_1, phi_1, theta_2, phi_2):
  with_env(CC: nil, CXX: nil) do
  system pythran, "-DUSE_XSIMD", "-fopenmp", "-march=native", testpath/"arc_distance.py"
  end
- rm_f testpath/"arc_distance.py"
+ rm(testpath/"arc_distance.py")
 
  system python3, "-c", <<~EOS
  import numpy as np