Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Sound Blaster Command App #83746

Merged
merged 7 commits into from
Jun 5, 2020
Merged

Add Sound Blaster Command App #83746

merged 7 commits into from
Jun 5, 2020

Commits on Jun 4, 2020

  1. Add files via upload

    @iMonZ
    iMonZ committed Jun 4, 2020
    Configuration menu
    Copy the full SHA
    e069ba5 View commit details
    Browse the repository at this point in the history

  2. Update sb-command.rb

    @iMonZ
    iMonZ committed Jun 4, 2020
    Configuration menu
    Copy the full SHA
    91a6c04 View commit details
    Browse the repository at this point in the history

  3. Update sb-command.rb 

    Sorry
    @iMonZ
    iMonZ committed Jun 4, 2020
    Configuration menu
    Copy the full SHA
    3486a38 View commit details
    Browse the repository at this point in the history

  4. Update sb-command.rb 

    Done!
I have used the Command: brew cask style Casks/sb-command.rb [--fix] from https://github.com/Homebrew/homebrew-cask/blob/master/doc/development/adding_a_cask.md

But this command doesn't fixed the offences
    @iMonZ
    iMonZ committed Jun 4, 2020
    Configuration menu
    Copy the full SHA
    5ad9b28 View commit details
    Browse the repository at this point in the history

  5. Update Casks/sb-command.rb 

    Hey thank you!

The name of the app after installing and on the Official Website is SB command!
The tool from homebrew suggested the name for the .rb file as SB-command.
So I need really to change this or let this at SB-command what is also better for the user cause of the same name on the website

Co-authored-by: Randall <[email protected]>
    @iMonZ @ran-dall
    iMonZ and ran-dall committed Jun 4, 2020
    Configuration menu
    Copy the full SHA
    c0ba5b2 View commit details
    Browse the repository at this point in the history

Commits on Jun 5, 2020

  1. Delete sb-command.rb

    @iMonZ
    iMonZ committed Jun 5, 2020
    Configuration menu
    Copy the full SHA
    45c056d View commit details
    Browse the repository at this point in the history

  2. Add files via upload

    @iMonZ
    iMonZ committed Jun 5, 2020
    Configuration menu
    Copy the full SHA
    174a570 View commit details
    Browse the repository at this point in the history