Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Cask for Now Desktop #29285

Closed
wants to merge 2 commits into from
Closed

Added Cask for Now Desktop #29285

wants to merge 2 commits into from

Conversation

leo
Copy link
Contributor

@leo leo commented Jan 22, 2017

My team at @zeit and I decided to add the application nevertheless.

When looking over this PR, please keep in mind that the download isn't versioned and we're also not distributing over tools like Github Releases, so I also left the appcast away.

I carefully read the documentation and made sure to align with it.


After making all changes to the cask:

  • brew cask audit --download {{cask_file}} is error-free.
  • brew cask style --fix {{cask_file}} reports no offenses.
  • The commit message includes the cask’s name and version.

Additionally, if adding a new cask:

  • Named the cask according to the token reference.
  • brew cask install {{cask_file}} worked successfully.
  • brew cask uninstall {{cask_file}} worked successfully.
  • Checked there are no open pull requests for the same cask.
  • Checked that the cask was not already refused in closed issues.

@vitorgalvao vitorgalvao added the awaiting user reply Issue needs response from a user. label Jan 22, 2017
@vitorgalvao
Copy link
Member

vitorgalvao commented Jan 22, 2017

Everything from #27397 still applies.

Please understand this: HBC is not your (or any single developer’s) personal distribution channel. We exist for the users, and users overwhelmingly (the ones that made their voices heard, at least) prefer versioned downloads for security reasons.

You cannot bend the rules to fit your case.

I prefer :latest and have made that clear when we were discussing this at the time. But even being the oldest active maintainer in HBC, I surrender to the evidence and let my preferences aside. In the end, HBC is for users.

You’re more than free and welcome to maintain your own tap for this software and direct your users there. Taps are by far my favourite feature of HB, as they make sure you aren’t confined to our rules for specific repos. You can make your own rules, and taps are incredibly easy to setup!

But if you want your apps in the official main repos, I ask that you follow our rules. They’re what keeps our sanity and project consistency amongst the flood of PRs we get everyday.

As I said before, if you as the maintainer are unwilling to add cask-repair -b -v {new_version} now to your build steps which does everything automatically, including submitting the PR, then I don’t want the submission to come from you as that signifies the cask will be left abandoned.

Lastly, please do not open repeated PRs when one gets rejected. Keep the discussion in the original one so we can solve the problem. Closing does not prevent further posting.

If you do change your mind, please do let us know. As it is, I see no difference between this and #27397.

@vitorgalvao vitorgalvao removed the awaiting user reply Issue needs response from a user. label Jan 22, 2017
@leo
Copy link
Contributor Author

leo commented Jan 22, 2017

Okay. I'm submitting a versioned one! 😊

Just explain this please. There are hundreds of these in the repo.

@vitorgalvao
Copy link
Member

Just explain this please. There are hundreds of these in the repo.

That one doesn’t have an auto_updates. As far as we know, it doesn’t auto update. It also may not have an appcast.

Or it may have both of those but we didn’t know it at the time. Maybe #6872 makes it clearer. You see, we do not accept casks that use an installer or pkg and that do not provide an uninstall. We require the latter to be present as well, for the cask to go through.

Now, those casks in that issue did go through at the time, and are indeed present, so what gives? Well, the answer is simple: they were added before the rule that would prevent them from being added was implemented. So that means we need to fix those and we don’t let anymore in to not exacerbate the problem.

This is the same thing.

Casks with such errors are usually fixed when they are discovered (just take a look at the recente excellent work by @colindunn to add missing appcasts).

Every time a rule is implemented, we can’t automatically fix all the present casks that disobeyed it. But we can be vigilant to the new ones, and fix the old ones as time permits. Not letting more errors creep through makes sure the task of fixing the old ones is a finite one, and that is paramount.

@Homebrew Homebrew locked and limited conversation to collaborators May 9, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants