Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add HMA! Pro VPN.app v. 3.2.11.2 #27160

Merged
merged 7 commits into from
Nov 28, 2016
Merged

Add HMA! Pro VPN.app v. 3.2.11.2 #27160

merged 7 commits into from
Nov 28, 2016

Conversation

rqelibari
Copy link
Contributor

@rqelibari rqelibari commented Nov 26, 2016

After making all changes to the cask:

  • brew cask audit --download {{cask_file}} is error-free.
  • brew cask style --fix {{cask_file}} reports no offenses.
  • The commit message includes the cask’s name and version.

Additionally, if adding a new cask:

  • Named the cask according to the [token reference].
  • brew cask install {{cask_file}} worked successfully.
  • brew cask uninstall {{cask_file}} worked successfully.
  • Checked there are no [open pull requests] for the same cask.
  • Checked that the cask was not already refused in [closed issues].

@vitorgalvao
Copy link
Member

It’s missing uninstall. There are scripts and documentation geared for that.

@vitorgalvao vitorgalvao added the awaiting user reply Issue needs response from a user. label Nov 27, 2016
@rqelibari
Copy link
Contributor Author

That is what I thought initially. But the little-snitch task has no uninstall neither.

So what is the reason it is needed here?

@vitorgalvao
Copy link
Member

Little Snitch also needs it. It’s just unfortunate it was merged before we started enforcing the rule.

@rqelibari
Copy link
Contributor Author

Actually having uninstalled enforced is good idea!
So I added all the files. The only file I don't know how to handle is the BootCache File in

/private/var/db/BootCaches/<SOME_ID_HERE>/app.com.privax.hmaprovpn.playlist

Does anyone know if it is ok to just remove this one?

@rqelibari
Copy link
Contributor Author

Thank you @vitorgalvao. Should have thought of formatting according to documentation!

@vitorgalvao vitorgalvao merged commit f7372f3 into Homebrew:master Nov 28, 2016
@vitorgalvao
Copy link
Member

Thank you.

@miccal miccal removed the awaiting user reply Issue needs response from a user. label Dec 23, 2016
@Homebrew Homebrew locked and limited conversation to collaborators May 9, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants