macdown-3000: add cli binary link #242810
Open
+3
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Looks like the CLI binary is not code-signed. I opened an upstream issue: schuyler/macdown3000#238 |
schuyler
added a commit
to schuyler/macdown3000
that referenced
this pull request
Dec 31, 2025
## Summary Add explicit code signing for the `macdown` CLI binary in the release workflow to ensure it passes Homebrew Cask's signature verification. ### Changes 1. **New "Sign CLI binary explicitly" step** (after build, before verification): - Signs CLI binary at `Contents/SharedSupport/bin/macdown` - Uses `--force --options runtime --timestamp` flags - Re-signs app bundle to update code signature seal 2. **Enhanced "Verify code signature" step**: - Verifies CLI binary signature with `codesign -vvv --strict` - Verifies Developer ID signing identity - Verifies hardened runtime flag is present 3. **Enhanced "Verify app bundle inside DMG" step**: - Verifies CLI binary exists in DMG - Verifies signature and Developer ID - Verifies hardened runtime flag ### Why this is needed The `CodeSignOnCopy` attribute in Xcode only performs basic code signing without hardened runtime or secure timestamp, which is insufficient for Homebrew Cask/Gatekeeper requirements. ## Related Issue Related to #238 ## Manual Testing Plan ### Phase 1: Workflow Verification - Trigger release workflow with a test tag - Verify workflow completes without errors in CLI signing steps ### Phase 2: Code Signature Verification ```bash # Verify CLI binary after mounting DMG CLI_PATH="/Volumes/MacDown 3000/MacDown 3000.app/Contents/SharedSupport/bin/macdown" codesign -vvv --strict "$CLI_PATH" codesign -dvv "$CLI_PATH" 2>&1 | grep "Authority=" # Should show Developer ID codesign -dvv "$CLI_PATH" 2>&1 | grep "flags=" # Should contain "runtime" ``` ### Phase 3: Homebrew Cask Verification - Update the Homebrew Cask PR at Homebrew/homebrew-cask#242810 - Verify CI passes code signing checks ## Review Notes - **Groucho (Architecture)**: Recommended adding explicit signing step after build with `--options runtime --timestamp` - **Chico (Code Review)**: Identified critical path issue (SharedSupport vs MacOS) and need to re-sign app bundle; both issues fixed - **Harpo (Docs)**: No documentation updates needed - existing docs describe signing at appropriate level - **Zeppo (Testing)**: Provided comprehensive manual testing plan for verifying signatures --------- Co-authored-by: Claude <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.
In the following questions
<cask>is the token of the cask you're submitting.After making any changes to a cask, existing or new, verify:
brew audit --cask --online <cask>is error-free.brew style --fix <cask>reports no offenses.Additionally, if adding a new cask:
brew audit --cask --new <cask>worked successfully.HOMEBREW_NO_INSTALL_FROM_API=1 brew install --cask <cask>worked successfully.brew uninstall --cask <cask>worked successfully.Link the CLI binary
macdownto enable command line access.