outguess: update livecheck #242764
Open
outguess: update livecheck #242764
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The existing `livecheck` block for `outguess` checks the homepage but requests to www.rbcafe.com fail with the default user agent, so this check fails and retries with the `:browser` user agent (which works). This adds `user_agent: :browser` to the `livecheck` block URL, so it will continue to work after we remove the user agent fallback behavior in livecheck.
samford
added
livecheck
BrewTestBot
added
the
missing description
BrewTestBot
removed
the
missing description
Member
Author
|
Hm, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.
In the following questions
<cask>is the token of the cask you're submitting.After making any changes to a cask, existing or new, verify:
brew audit --cask --online <cask>is error-free.brew style --fix <cask>reports no offenses.Additionally, if adding a new cask:
brew audit --cask --new <cask>worked successfully.HOMEBREW_NO_INSTALL_FROM_API=1 brew install --cask <cask>worked successfully.brew uninstall --cask <cask>worked successfully.The existing
livecheckblock foroutguesschecks the homepage but requests to www.rbcafe.com fail with the default user agent, so this check fails and retries with the:browseruser agent (which works). This addsuser_agent: :browserto thelivecheckblock URL, so it will continue to work after we remove the user agent fallback behavior in livecheck.I've set this to skip the homepage audit because it will predictably fail without a
:browseruser agent.