Adding Belgian EID middleware #217711
Adding Belgian EID middleware #217711
Conversation
BrewTestBot
added
new cask
missing zap
Casks/e/eid-mw.rb
Outdated
| livecheck do | ||
| skip "No version info available" | ||
| end |
There was a problem hiding this comment.
Whatever livecheck we end up with for eid-viewer we can replicate here.
There was a problem hiding this comment.
I struggle to understand what is breaking here. It was the initial reason why I skipped the livecheck
There was a problem hiding this comment.
The current snippet is not working and I don't know how to make it work. It feels like I'm close but I'm not getting it
| @@ -0,0 +1,20 @@ | |||
| cask "eid-mw" do | |||
There was a problem hiding this comment.
What is the name of the app that is installed by this pkg?
Is it "eID MW.app"?
There was a problem hiding this comment.
No. The name of the app is "BEID token". However, the Belgian website calls it eid-middleware
There was a problem hiding this comment.
I can't see any reference to eid-middleware on the website, I feel like the token beid-token may be a better fit here?
There was a problem hiding this comment.
It's not mentionned on : https://eid.belgium.be/en
However, the government calls it eid middleware (https://www.ibz.rrn.fgov.be/fr/citoyen/documents-didentite/eid/eid-middleware) and the project is available on github as eid-mw https://github.com/Fedict/eid-mw
But from what I know, the github version is hard to use as it feels like the repo is not well maintained (which is sad)
There was a problem hiding this comment.
Please try to add a zap stanza. The linked documentation provides some recommended methods to create it.
|
zap script says that there is no need for zap on this one |
Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.
In the following questions
<cask>is the token of the cask you're submitting.After making any changes to a cask, existing or new, verify:
brew audit --cask --online <cask>is error-free.brew style --fix <cask>reports no offenses.Additionally, if adding a new cask:
brew audit --cask --new <cask>worked successfully.HOMEBREW_NO_INSTALL_FROM_API=1 brew install --cask <cask>worked successfully.brew uninstall --cask <cask>worked successfully.