Skip to content

pale-moon 33.7.2 (new cask) #214703

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 10, 2025
Merged

Conversation

synkathairo
Copy link
Contributor

@synkathairo synkathairo commented Jun 2, 2025

Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.

In the following questions <cask> is the token of the cask you're submitting.

After making any changes to a cask, existing or new, verify:

Additionally, if adding a new cask:

  • Named the cask according to the token reference.
  • Checked the cask was not already refused (add your cask's name to the end of the search field).
  • brew audit --cask --new <cask> worked successfully.
  • HOMEBREW_NO_INSTALL_FROM_API=1 brew install --cask <cask> worked successfully.
  • brew uninstall --cask <cask> worked successfully.

@synkathairo
Copy link
Contributor Author

synkathairo commented Jun 2, 2025

so it seems the test fails because I set the intel mac version to depend on lion or later (10.7)
(see https://www.palemoon.org/download.shtml)
should I set it to something later based on the latest macos version supported by homebrew?

@synkathairo synkathairo changed the title palemoon 33.7.1 palemoon 33.7.1 (new cask) Jun 2, 2025
@synkathairo
Copy link
Contributor Author

synkathairo commented Jun 2, 2025

macOS on ARM requires software to be signed. fails the macos-13, intel check? Is codesigning required for the intel version as well? If so, maybe the intel version should be removed from the cask? It seems like Pale Moon only signed the ARM version of the cask?

@synkathairo synkathairo force-pushed the palemoon-33.7.1 branch 2 times, most recently from 377f0bd to 8bb7ee7 Compare June 2, 2025 22:19
@synkathairo
Copy link
Contributor Author

now edited to remove the Intel version which blocked checks (due to being unsigned)

@synkathairo synkathairo force-pushed the palemoon-33.7.1 branch 3 times, most recently from c1d6c0a to 68a1912 Compare June 2, 2025 22:41
@khipp khipp force-pushed the palemoon-33.7.1 branch from 1153576 to cceed73 Compare June 4, 2025 17:29
@khipp khipp force-pushed the palemoon-33.7.1 branch from cceed73 to b32997d Compare June 4, 2025 17:32
@khipp khipp changed the title palemoon 33.7.1 (new cask) pale-moon 33.7.2 (new cask) Jun 4, 2025
@synkathairo synkathairo requested a review from bevanjkay June 8, 2025 19:56
@bevanjkay bevanjkay added this pull request to the merge queue Jun 10, 2025
Merged via the queue into Homebrew:master with commit ff46113 Jun 10, 2025
9 checks passed
@EricFromCanada
Copy link
Member

Apparently the Intel builds are intentionally unsigned.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants