Skip to content

Comments

bambu-connect 1.2.1-beta.5 (new cask)#206724

Merged
bevanjkay merged 1 commit intoHomebrew:masterfrom
sethiele:bambu-connect
Mar 29, 2025
Merged

bambu-connect 1.2.1-beta.5 (new cask)#206724
bevanjkay merged 1 commit intoHomebrew:masterfrom
sethiele:bambu-connect

Conversation

@sethiele
Copy link
Contributor

@sethiele sethiele commented Mar 28, 2025

Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.

In the following questions <cask> is the token of the cask you're submitting.

After making any changes to a cask, existing or new, verify:

Additionally, if adding a new cask:

  • Named the cask according to the token reference.
  • Checked the cask was not already refused (add your cask's name to the end of the search field).
  • brew audit --cask --new <cask> worked successfully.
  • HOMEBREW_NO_INSTALL_FROM_API=1 brew install --cask <cask> worked successfully.
  • brew uninstall --cask <cask> worked successfully.

@BrewTestBot BrewTestBot added automerge-skip new cask missing zap Cask is missing a zap stanza, please add one. labels Mar 28, 2025
@sethiele sethiele changed the title Bambu connect Bambu Connect 1.2.1-beta.5 (new cask) Mar 28, 2025
Copy link
Member

@khipp khipp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your first contribution to homebrew-cask, @sethiele! 🎉

I left a few suggestions below. Please also try to add a zap stanza. The linked documentation provides some recommended methods to create it.

@khipp khipp changed the title Bambu Connect 1.2.1-beta.5 (new cask) bambu-connect 1.2.1-beta.5 (new cask) Mar 28, 2025
sethiele added a commit to sethiele/homebrew-cask that referenced this pull request Mar 28, 2025
@BrewTestBot BrewTestBot removed the missing zap Cask is missing a zap stanza, please add one. label Mar 28, 2025
@sethiele
Copy link
Contributor Author

@khipp Thank you, I appreciate it. I merged all your comments. Thanks for your help.

Add Bambu Connect to the cask library.
@bevanjkay bevanjkay merged commit eea752a into Homebrew:master Mar 29, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants