-
-
Notifications
You must be signed in to change notification settings - Fork 10.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ijhttp-cli 243.24978.46 (new cask) #206440
base: master
Are you sure you want to change the base?
Conversation
Thank you for your submission @bartekpacia. We are unable to accept it at this time because it does not pass Homebrew's signature verification check:
Please consider hosting this in your own Tap and if the developers sign their app in the future we would be happy to consider adding this to |
Hi @p-linnane, thanks for a quick response! I work at JetBrains, who is the developer of the app in question. We're working on fixing the signature problem. Thanks! |
@@ -0,0 +1,21 @@ | |||
cask "ijhttp-cli" do |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Based on our token reference guidelines the token here should just be ijhttp
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, thanks for the review.
To add some context why I chose to add the -cli
suffix: in the future, we may create a standalone HTTP client.
But if you think it's not a strong enough justification, I'm fine with renaming to just ijhttp
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's name it ijhttp
for now. We can use ijhttp-client
or something for the other component.
Regexs found with the help of: https://rubular.com
98e938a
to
ddd9f57
Compare
Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.
In the following questions
<cask>
is the token of the cask you're submitting.After making any changes to a cask, existing or new, verify:
brew audit --cask --online <cask>
is error-free.brew style --fix <cask>
reports no offenses.Additionally, if adding a new cask:
brew audit --cask --new <cask>
worked successfully.HOMEBREW_NO_INSTALL_FROM_API=1 brew install --cask <cask>
worked successfully.brew uninstall --cask <cask>
worked successfully.YouTrack ticket: https://youtrack.jetbrains.com/issue/IJPL-181991/Add-HTTP-client-CLI-to-Homebrew