Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ijhttp-cli 243.24978.46 (new cask) #206440

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bartekpacia
Copy link

@bartekpacia bartekpacia commented Mar 26, 2025

Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.

In the following questions <cask> is the token of the cask you're submitting.

After making any changes to a cask, existing or new, verify:

Additionally, if adding a new cask:

  • Named the cask according to the token reference.
  • Checked the cask was not already refused (add your cask's name to the end of the search field).
  • brew audit --cask --new <cask> worked successfully.
  • HOMEBREW_NO_INSTALL_FROM_API=1 brew install --cask <cask> worked successfully.
  • brew uninstall --cask <cask> worked successfully.

YouTrack ticket: https://youtrack.jetbrains.com/issue/IJPL-181991/Add-HTTP-client-CLI-to-Homebrew

@BrewTestBot BrewTestBot added new cask missing zap Cask is missing a zap stanza, please add one. labels Mar 26, 2025
@bartekpacia bartekpacia changed the title ijhttp 243.24978.46 (new cask) ijhttp-cli 243.24978.46 (new cask) Mar 26, 2025
@p-linnane
Copy link
Member

Thank you for your submission @bartekpacia. We are unable to accept it at this time because it does not pass Homebrew's signature verification check:

macOS on ARM requires applications to be signed. Please contact the upstream developer to let them know they should sign their app.

Please consider hosting this in your own Tap and if the developers sign their app in the future we would be happy to consider adding this to homebrew-cask.

@p-linnane p-linnane closed this Mar 26, 2025
@bartekpacia
Copy link
Author

Hi @p-linnane, thanks for a quick response!

I work at JetBrains, who is the developer of the app in question. We're working on fixing the signature problem.
I'd appreciate if this PR could be re-opened (or I can convert it into a draft).

Thanks!

@p-linnane p-linnane reopened this Mar 26, 2025
@@ -0,0 +1,21 @@
cask "ijhttp-cli" do
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on our token reference guidelines the token here should just be ijhttp.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thanks for the review.

To add some context why I chose to add the -cli suffix: in the future, we may create a standalone HTTP client.

But if you think it's not a strong enough justification, I'm fine with renaming to just ijhttp.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's name it ijhttp for now. We can use ijhttp-client or something for the other component.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
missing zap Cask is missing a zap stanza, please add one. new cask
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants