Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consul: migrate formula to casks #200992

Merged
merged 1 commit into from
Mar 3, 2025
Merged

Conversation

botantony
Copy link
Contributor

Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.

In the following questions <cask> is the token of the cask you're submitting.

After making any changes to a cask, existing or new, verify:

Additionally, if adding a new cask:

  • Named the cask according to the token reference.
  • Checked the cask was not already refused (add your cask's name to the end of the search field).
  • brew audit --cask --new <cask> worked successfully.
  • HOMEBREW_NO_INSTALL_FROM_API=1 brew install --cask <cask> worked successfully.
  • brew uninstall --cask <cask> worked successfully.

this formula was deprecated almost one year ago and yet it is still being used (see analytics) and some formulae use it as a dependency. i think it would be better to at least migrate this formula to casks rather than removing it from the official repo completely

p.s. for some reasons brew audit --cask --new consul prints consul is listed in tap_migrations.json despite being removed from the list

@botantony

This comment was marked as outdated.

This comment was marked as outdated.

@github-actions github-actions bot added the stale Issue which has not received any feedback for some time. label Mar 2, 2025
@botantony

This comment was marked as outdated.

@github-actions github-actions bot removed the stale Issue which has not received any feedback for some time. label Mar 2, 2025
@bevanjkay
Copy link
Member

Did you mean to remove the cask file on the latest force-push?

@botantony
Copy link
Contributor Author

until this pr is not merged i do not think it is a good idea to create the cask version of this formula

Copy link
Member

@bevanjkay bevanjkay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy to decouple this from adding the new formula, but the PR in homebrew-core also can't be merged until the target casks exists againhere.

@bevanjkay bevanjkay merged commit 1c2e777 into Homebrew:master Mar 3, 2025
9 checks passed
@khipp khipp mentioned this pull request Mar 4, 2025
8 tasks
@botantony botantony deleted the consul branch March 4, 2025 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants