tableau-prep, tableau-reader 2024.3.1 #193913
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samford
added
the
ci-skip-livecheck
samford
added
the
ci-skip-homepage
The existing `homepage` for `tableau-prep` returns a 403 (Forbidden) response on CI like any www.tableau.com/support/ URL. This updates the `homepage` to use a URL that should work on CI and aligns with the `tableau` and `tableau-reader` casks.
samford
removed
the
ci-skip-homepage
samford
force-pushed
the
various-tableau-2024.3.1
branch
from
e326798 to
a7b070d
Compare
chenrui333
approved these changes
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.
In the following questions
<cask>is the token of the cask you're submitting.After making any changes to a cask, existing or new, verify:
brew audit --cask --online <cask>is error-free.brew style --fix <cask>reports no offenses.Additionally, if adding a new cask:
brew audit --cask --new <cask>worked successfully.HOMEBREW_NO_INSTALL_FROM_API=1 brew install --cask <cask>worked successfully.brew uninstall --cask <cask>worked successfully.This updates the
tableau-prepandtableau-readercasks to 2024.3.1, as is being done fortableauin #193816 andtableau-publicin #191077.I've applied the
ci-skip-livechecklabel, as this will fail CI otherwise. At the moment, it would fail because thetableaulivecheckblock is checking an XML file that only returns 2024.2.4 as the latest version (instead of 2024.3.1). If/when #193816 is merged, the updatedlivecheckblock will return the correct latest version locally but will fail on CI, so we will have to continue skipping livecheck for the various Tableau casks unless/until upstream reliably updates the XML file and we can return to checking that (which doesn't fail on CI).Like the aforementioned
livecheckblock changes, the homepage fortableau-prepuses a www.tableau.com/support/ page, so it will also encounter a 403 (Forbidden) response on CI. This updates thehomepageto the product page, which shouldn't fail on CI and aligns with thehomepageURLs fortableauandtableau-reader.