-
-
Notifications
You must be signed in to change notification settings - Fork 10.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tuist: deprecate #193538
base: master
Are you sure you want to change the base?
tuist: deprecate #193538
Conversation
2edcb23
to
8eb24d9
Compare
Yup, this is what we’d be more likely to accept. Presumably the app can also install the CLI so that feels like a good middle ground. |
The CLI and app have different versions, so I'm not sure how that would work with the |
Could the |
There's a tiny bit of the CLI that's closed source, which we hope to change in the future. We do have a formula for it in our own repo: https://github.com/tuist/homebrew-tuist/tree/main/Formula. I updated the cask to be our macOS app instead. |
@fortmarek Does this cask also install the CLI? If not, I'm inclined to say this should be a new Cask called |
We've already tried to remove this cask in the past: #180746
It causes issues for us as maintainers of Tuist. The cask was not added by a maintainer of Tuist and the maintainers have not approved of that: #145456. Additionally, as reasoned here, we don't think the cask should have been approved by the Homebrew team in the first place – even when not considering maintainers' (dis)approval
We much prefer to maintain our formulae and casks in our own repository: https://github.com/tuist/homebrew-tuist
Additionally, we added a cask for our new macOS app while this cask points to a CLI.
That means the only way for our users to download our official macOS cask, they have to run
brew install --cask tuist/tuist/tuist
– that is use the fully qualified name, instead of just runningbrew tap tuist/tuist && brew install --cask tuist
.We'd very much like to go forward with a deprecation period followed up with the removal of this cask.
If this is not an option, we'd need to change this cask to instead download our app, not the CLI. That, however, feels like a breaking change as
brew install tuist
will suddenly download something completely different.Our clear preference is for removal of this cask, but if there is no other way, would the Homebrew team accept this cask to be changed to download an app binary instead of a CLI?
After making any changes to a cask, existing or new, verify:
brew audit --cask --online <cask>
is error-free.brew style --fix <cask>
reports no offenses.Additionally, if adding a new cask:
brew audit --cask --new <cask>
worked successfully.HOMEBREW_NO_INSTALL_FROM_API=1 brew install --cask <cask>
worked successfully.brew uninstall --cask <cask>
worked successfully.