Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add one more useful step to CONTRIBUTING.md #191427

Closed
wants to merge 1 commit into from

Conversation

unreturned
Copy link
Contributor

Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.

In the following questions <cask> is the token of the cask you're submitting.

After making any changes to a cask, existing or new, verify:

Additionally, if adding a new cask:

  • Named the cask according to the token reference.
  • Checked the cask was not already refused (add your cask's name to the end of the search field).
  • brew audit --cask --new <cask> worked successfully.
  • HOMEBREW_NO_INSTALL_FROM_API=1 brew install --cask <cask> worked successfully.
  • brew uninstall --cask <cask> worked successfully.

Just add one more useful command to contributing guide because I try to use command brew bump --open-pr yandex-cloud-cli but have error like this:

~$ brew bump yandex-cloud-cli
Error: These casks are not in any locally installed taps!

  yandex-cloud-cli

You may need to run `brew tap` to install additional taps.

I founded here, that I need command brew tap homebrew/cask, but also have error (but with hint :)):

~$ brew tap homebrew/cask
Error: Tapping homebrew/cask is no longer typically necessary.
Add --force if you are sure you need it for contributing to Homebrew.

After use brew tap --force homebrew/cask I can do the main thing that I wanted - bump cask.
It would be nice to have this instruction in contributing guide.

@BrewTestBot BrewTestBot added automerge-skip documentation Issue regarding documentation. labels Nov 8, 2024
@SMillerDev
Copy link
Member

That's one of the steps in:

Follow the guide in How to Open a Homebrew Pull Request.

@unreturned
Copy link
Contributor Author

That's one of the steps in:

Follow the guide in How to Open a Homebrew Pull Request.

Good! Maybe this guide could be linked in CONTRIBUTING.md?

@SMillerDev
Copy link
Member

It's on line 29

@unreturned unreturned closed this Nov 11, 2024
@unreturned unreturned deleted the update_contributing branch November 11, 2024 17:01
@unreturned
Copy link
Contributor Author

Yep, my bad :) thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge-skip documentation Issue regarding documentation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants