Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aide-app 1.94.2.24317 (new cask) #191230

Merged
merged 1 commit into from
Nov 12, 2024
Merged

Conversation

aaditkamat
Copy link
Contributor

@aaditkamat aaditkamat commented Nov 7, 2024

Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.

In the following questions <cask> is the token of the cask you're submitting.

After making any changes to a cask, existing or new, verify:

Additionally, if adding a new cask:

  • Named the cask according to the token reference.
  • Checked the cask was not already refused (add your cask's name to the end of the search field).
  • brew audit --cask --new <cask> worked successfully.
  • HOMEBREW_NO_INSTALL_FROM_API=1 brew install --cask <cask> worked successfully.
  • brew uninstall --cask <cask> worked successfully.

@aaditkamat aaditkamat force-pushed the add-aide branch 2 times, most recently from 46477f7 to d428577 Compare November 7, 2024 01:10
@daeho-ro daeho-ro changed the title Aide 1.94.2 aide-app 1.94.2 (new cask) Nov 7, 2024
@bevanjkay bevanjkay added the ci-skip-repository Skip repository checks on CI. Use only after repository has been verified manually. label Nov 9, 2024
Casks/a/aide-app.rb Outdated Show resolved Hide resolved
@daeho-ro
Copy link
Member

daeho-ro commented Nov 9, 2024

@aaditkamat , Thanks for your contribution! I left some comments on the code, please check it.

Casks/a/aide-app.rb Outdated Show resolved Hide resolved
Casks/a/aide-app.rb Outdated Show resolved Hide resolved
@khipp khipp changed the title aide-app 1.94.2 (new cask) aide-app 1.94.2.24313 (new cask) Nov 9, 2024
@khipp
Copy link
Member

khipp commented Nov 10, 2024

@aaditkamat You still need to rename the file to aide.rb. Please also squash your commits to keep the history cleaner. Thanks!

@daeho-ro daeho-ro changed the title aide-app 1.94.2.24313 (new cask) aide 1.94.2.24313 (new cask) Nov 10, 2024
Casks/a/aide-app.rb Outdated Show resolved Hide resolved
@daeho-ro daeho-ro self-requested a review November 10, 2024 21:49
@daeho-ro
Copy link
Member

daeho-ro commented Nov 10, 2024

The name is duplicate with a formula but it seems that they are not related. How can we pass this? Maybe this is the reason why the name was aide-app 😅

@aaditkamat
Copy link
Contributor Author

The name is duplicate with a formula but it seems that they are not related. How can we pass this? Maybe this is the reason why the name was aide-app 😅

Yes that's why I had named the cask that way. But I thought that you were ok with making the exception to the cask name being different from the file name

@daeho-ro daeho-ro changed the title aide 1.94.2.24313 (new cask) aide-app 1.94.2.24313 (new cask) Nov 11, 2024
@khipp khipp force-pushed the add-aide branch 2 times, most recently from f99b3c6 to 89aea63 Compare November 11, 2024 17:27
Copy link
Member

@khipp khipp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @aaditkamat!

Casks/a/aide-app.rb Outdated Show resolved Hide resolved
@krehel
Copy link
Member

krehel commented Nov 11, 2024

We are going to need to either rename the binary, forgo installing it, or implement conflicts_with: aide

I installed aide the formula, and then we would get this -

Error: It seems there is already a Binary at '/opt/homebrew/bin/aide'

Casks/a/aide.rb Outdated Show resolved Hide resolved
Co-authored-by: Bevan Kay <[email protected]>
Co-authored-by: Klaus Hipp <[email protected]>
@khipp khipp changed the title aide-app 1.94.2.24313 (new cask) aide-app 1.94.2.24317 (new cask) Nov 12, 2024
@bevanjkay bevanjkay merged commit ad6d3fe into Homebrew:master Nov 12, 2024
8 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-skip-repository Skip repository checks on CI. Use only after repository has been verified manually. new cask notability
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants