-
-
Notifications
You must be signed in to change notification settings - Fork 10.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
aide-app 1.94.2.24317 (new cask) #191230
aide-app 1.94.2.24317 (new cask) #191230
Conversation
46477f7
to
d428577
Compare
@aaditkamat , Thanks for your contribution! I left some comments on the code, please check it. |
@aaditkamat You still need to rename the file to |
The name is duplicate with a formula but it seems that they are not related. How can we pass this? Maybe this is the reason why the name was |
Yes that's why I had named the cask that way. But I thought that you were ok with making the exception to the cask name being different from the file name |
f99b3c6
to
89aea63
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @aaditkamat!
We are going to need to either rename the binary, forgo installing it, or implement I installed
|
Co-authored-by: Bevan Kay <[email protected]> Co-authored-by: Klaus Hipp <[email protected]>
Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.
In the following questions
<cask>
is the token of the cask you're submitting.After making any changes to a cask, existing or new, verify:
brew audit --cask --online <cask>
is error-free.brew style --fix <cask>
reports no offenses.Additionally, if adding a new cask:
brew audit --cask --new <cask>
worked successfully.HOMEBREW_NO_INSTALL_FROM_API=1 brew install --cask <cask>
worked successfully.brew uninstall --cask <cask>
worked successfully.