Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mamp@6 6.9 (new cask) #180620

Closed
wants to merge 2 commits into from
Closed

mamp@6 6.9 (new cask) #180620

wants to merge 2 commits into from

Conversation

WilliamIsted
Copy link

With MAMP Pro 7 being a paid for update, support should be kept for MAMP Pro 6.

Ref: 7481fac

Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.

In the following questions <cask> is the token of the cask you're submitting.

After making any changes to a cask, existing or new, verify:

Additionally, if adding a new cask:

  • Named the cask according to the token reference.
  • Checked the cask was not already refused (add your cask's name to the end of the search field).
  • brew audit --cask --new <cask> worked successfully.
  • HOMEBREW_NO_INSTALL_FROM_API=1 brew install --cask <cask> worked successfully.
  • brew uninstall --cask <cask> worked successfully.

With MAMP Pro 7 being a paid for update, support should be kept for MAMP Pro 6.

Ref: Homebrew@7481fac
Add version to cask name
@SMillerDev
Copy link
Member

Will upstream keep supporting this version?

@WilliamIsted
Copy link
Author

Will upstream keep supporting this version?

I have reached out to the author to clarify if MAMP 6 will continue to be supported with updates / security patches. I'll update this PR once I have a reply.

Aside: MAMP 7 moves to a subscription model with updates being limited by an active subscription so the latest version of 7 will only be usable for active subscribers unlike 6. It would be useful to keep 6 for existing users who don't want to move to a subscription model.

@p-linnane p-linnane added upstream Issue which needs to be resolved by the upstream project. awaiting user reply Issue needs response from a user. labels Jul 28, 2024
@p-linnane p-linnane changed the title Add support for recently replaced MAMP Pro 6 mamp@6 6.9 (new cask) Jul 28, 2024
@@ -0,0 +1,48 @@
cask "mamp@6" do
arch arm: "M1-arm", intel: "Intel-x86"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
arch arm: "M1-arm", intel: "Intel-x86"
arch arm: "Apple-chip", intel: "Intel-x86"


livecheck do
url "https://www.mamp.info/en/downloads/"
regex(%r{href=.*?/MAMP[._-]MAMP[._-]PRO[._-]v?(\d+(?:\.\d+)+)[._-]#{arch}\.pkg}i)
Copy link
Member

@bevanjkay bevanjkay Jul 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
regex(%r{href=.*?/MAMP[._-]MAMP[._-]PRO[._-]v?(\d+(?:\.\d+)+)[._-]#{arch}\.pkg}i)
regex(%r{href=.*?/MAMP[._-]MAMP[._-]PRO[._-]v?(#{version.major}(?:\.\d+)+)[._-]#{arch}\.pkg}i)

@p-linnane
Copy link
Member

Closing due to lack of response.

@p-linnane p-linnane closed this Aug 11, 2024
@t-fritsch
Copy link

I have reached out to the author to clarify if MAMP 6 will continue to be supported with updates / security patches. I'll update this PR once I have a reply.

hello @WilliamIsted ! did mamp team reply ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting user reply Issue needs response from a user. new cask upstream Issue which needs to be resolved by the upstream project.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants