Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adobe-acrobat-reader 24.002.20964 #180517

Merged
merged 1 commit into from
Jul 29, 2024
Merged

Conversation

dalisoft
Copy link
Contributor

Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.

In the following questions <cask> is the token of the cask you're submitting.

After making any changes to a cask, existing or new, verify:

Additionally, if adding a new cask:

  • Named the cask according to the token reference.
  • Checked the cask was not already refused (add your cask's name to the end of the search field).
  • brew audit --cask --new <cask> worked successfully.
  • HOMEBREW_NO_INSTALL_FROM_API=1 brew install --cask <cask> worked successfully.
  • brew uninstall --cask <cask> worked successfully.

@chenrui333 chenrui333 changed the title Update adobe-acrobat-reader to v24.002.20964 adobe-acrobat-reader 24.002.20964 Jul 24, 2024
@chenrui333
Copy link
Member

 - Version '24.002.20964' differs from '24.002.20857' retrieved by livecheck.
 - Version '24.002.20964' differs from '24.002.20857' retrieved by livecheck.
 - The homepage URL https://acrobat.adobe.com/us/en/acrobat/pdf-reader.html is not reachable (HTTP status code 301)
adobe-acrobat-reader
  * Version '24.002.20964' differs from '24.002.20857' retrieved by livecheck.
  * The homepage URL https://acrobat.adobe.com/us/en/acrobat/pdf-reader.html is not reachable (HTTP status code 301)

@p-linnane p-linnane added the ci-retry Continuously re-runs CI until it succeeds or is cancelled. label Jul 24, 2024
@bevanjkay
Copy link
Member

This may not receive an actual full installer. Some versions only receive patches.

@khipp
Copy link
Member

khipp commented Jul 24, 2024

@bevanjkay The binary seems to have the correct size (source). I found a corresponding livecheck thanks to Proxyman. ❤️

@bevanjkay
Copy link
Member

I think we use to use that feed but changed for a reason - it's probably in the git history. I can check a bit later unless you get there first.

@dalisoft
Copy link
Contributor Author

I found the change with git blame

#169567

@p-linnane
Copy link
Member

Our livecheck is correct. If you go to Adobe's site and try to download it pulls down v24.002.20857. We can't update the cask unless Adobe ships a new installer as @bevanjkay stated.

@p-linnane p-linnane closed this Jul 28, 2024
@khipp
Copy link
Member

khipp commented Jul 29, 2024

The download page and livecheck version have finally been updated.

@khipp khipp reopened this Jul 29, 2024
@khipp khipp added the ci-skip-homepage Skip homepage checks on CI. Use only after homepage has been verified manually. label Jul 29, 2024
@p-linnane p-linnane merged commit ab34ddb into Homebrew:master Jul 29, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-retry Continuously re-runs CI until it succeeds or is cancelled. ci-skip-homepage Skip homepage checks on CI. Use only after homepage has been verified manually.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants