Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mamp: update sha256 #180318

Merged
merged 1 commit into from
Jul 29, 2024
Merged

mamp: update sha256 #180318

merged 1 commit into from
Jul 29, 2024

Conversation

JipSterk
Copy link
Contributor

Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.

In the following questions <cask> is the token of the cask you're submitting.

After making any changes to a cask, existing or new, verify:

@p-linnane
Copy link
Member

Please reach out to upstream and ask if this was an intentional change. We need to be sure this was not a malicious act.

@p-linnane p-linnane added the awaiting user reply Issue needs response from a user. label Jul 23, 2024
@JipSterk
Copy link
Contributor Author

hi @p-linnane i'm not sure what you mean with reaching out to upstream. yesterday i tried installing mamp but i was confronted with the following error:
Screenshot 2024-07-23 at 08 46 01
when i delete the file mentioned above it just downloads from the same source and will produce the same sha256. also i tried looking up a flag or option to ignore the sha check but to no avail. i tried the following to update the sha256 using this command:

brew bump-cask-pr mamp --sha256=2f0c89c0682247c5543706911513af17304bd39d3a324473f8f919acad3a7fdd

but then i'm confronted with the following error:

Error: Cask 'mamp' is unavailable: No Cask with this name exists.

so opening a pr this way felt like the only other way to update the sha256.
i'm just someone who uses mamp for work. But am in no way affiliated with mamp, their business and have no way of verifying whether the download is any good. i hope i've provided you with enough context

@p-linnane
Copy link
Member

Right. I'm asking you to contact the MAMP team and ask if this hash change is expected. Either they reuploaded the release without changing the version, or a malicious actor made changes to the release. We need to understand why the hash changed before we merge this in case it's a security issue.

khipp referenced this pull request Jul 25, 2024
@khipp
Copy link
Member

khipp commented Jul 25, 2024

I opened a ticket in their bug tracker and will report back once I get an update.

@p-linnane p-linnane added the upstream Issue which needs to be resolved by the upstream project. label Jul 28, 2024
@p-linnane p-linnane changed the title Update sha for arm on mamp.rb mama: update sha256 Jul 28, 2024
@bevanjkay bevanjkay changed the title mama: update sha256 mamp: update sha256 Jul 29, 2024
@khipp
Copy link
Member

khipp commented Jul 29, 2024

Screenshot 2024-07-29 at 15 21 01

It seems like upstream is not aware of any tampering. Both theirs and our checksums can be matched to the latest binaries (not that this proves anything, but they are current):

$ find . -type f -exec shasum -a 256 {} \; -exec shasum -a 512 {} \;
2f0c89c0682247c5543706911513af17304bd39d3a324473f8f919acad3a7fdd  ./MAMP-MAMP-PRO-7.0-Apple-chip.pkg
d6bef3a4e309aec3a8d0e883a031f95b25be5f615662910d22f990d9c48e1940b4da00dc54b9d468bd0aec229b7553fe19694efe6e7e3923c1c35a5cfe4d33c9  ./MAMP-MAMP-PRO-7.0-Apple-chip.pkg
80b680cb002fdfeccd43bb4de8f73ea071d21544e9a024ffd0bab21eb2e8ecca  ./MAMP-MAMP-PRO-7.0-Intel-x86.pkg
cd48bfdfed51dc69378f74c59ec005a3f735042c91e4f1e96bc4d61c4ab362c97bfa2d9d2a5d020213e8f4bab373c6e1e6f460549a8a18df0fc667769c2d581c  ./MAMP-MAMP-PRO-7.0-Intel-x86.pkg

@p-linnane p-linnane removed the awaiting user reply Issue needs response from a user. label Jul 29, 2024
@p-linnane p-linnane enabled auto-merge July 29, 2024 15:11
@p-linnane p-linnane merged commit fcfba5f into Homebrew:master Jul 29, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
checksum-mismatch upstream Issue which needs to be resolved by the upstream project.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants