Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*casks: : Avoid using FileUtils#rm_rf, FileUtils#rm_f or Pathname#rmtree #179540

Merged
merged 6 commits into from
Jul 14, 2024

Conversation

issyl0
Copy link
Member

@issyl0 issyl0 commented Jul 14, 2024

Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.

In the following questions <cask> is the token of the cask you're submitting.

After making any changes to a cask, existing or new, verify:


@issyl0 issyl0 added the ci-syntax-only Only run syntax checks on CI. Use only for bulk changes. label Jul 14, 2024
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks right!

@issyl0 issyl0 marked this pull request as ready for review July 14, 2024 18:23
@issyl0 issyl0 merged commit b3992ec into master Jul 14, 2024
11 checks passed
@issyl0 issyl0 deleted the rubocop-fix-rmrf-usage branch July 14, 2024 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge-skip ci-syntax-only Only run syntax checks on CI. Use only for bulk changes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants