Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v2rayu 4.2.1 #178825

Closed
wants to merge 1 commit into from
Closed

v2rayu 4.2.1 #178825

wants to merge 1 commit into from

Conversation

i0ntempest
Copy link
Contributor

Created with brew bump-cask-pr.

@BrewTestBot BrewTestBot added the bump-cask-pr PR was created using `brew bump-cask-pr` label Jul 7, 2024
@i0ntempest i0ntempest closed this Jul 7, 2024
@i0ntempest i0ntempest deleted the bump-v2rayu-4.2.1 branch July 7, 2024 19:07
@i0ntempest i0ntempest restored the bump-v2rayu-4.2.1 branch July 7, 2024 19:08
@i0ntempest i0ntempest reopened this Jul 7, 2024
@i0ntempest
Copy link
Contributor Author

Again, updating from a prerelease to another prerelease. 4.2.2 is the same build but with no signature so do not update.

@p-linnane
Copy link
Member

I'm not exactly sure what's going on with this cask. The hashes are the same for each architecture. We should downgrade this to whatever is the latest stable signed release. If they are not planning to sign releases in the future, this should be deprecated instead. cc @Homebrew/cask for additional thoughts.

@p-linnane p-linnane added the awaiting maintainer feedback Issue needs response from a maintainer. label Jul 9, 2024
@i0ntempest
Copy link
Contributor Author

They seem to be releasing two versions for each build, one signed and one not signed. I’m definitely against downgrading though, the new config file is incompatible with the old version and will break everyone’s installation.

@p-linnane
Copy link
Member

Agreed that we should not downgrade if it will break things for users.

We should probably open an upstream issue asking for clarification on their release process so we can handle this correctly moving forward. I'd like to understand the use of pre-releases, the signed/unsigned situation, and why/how both architectures have the exact same hash. @i0ntempest Do you happen to speak Mandarin? If so, would you be comfortable opening an issue? If not, I can open one but it would be in English.

@i0ntempest
Copy link
Contributor Author

I do. I’ll ask for some clarification once I get time.
I think they previously have separated x86 and arm build, but the app is now universal and they didn’t bother to change file name.
But that’s just my speculation. I’ll ask what’s going on.

@i0ntempest
Copy link
Contributor Author

Opened a discussion to ask for clarification.
What I know now is the developer had his old certificated revoked, so the old 3.8 (maybe also 4.2.0 and 4.2.1) now have invalid signatures, and the recently released 3.9 (which is just 3.8 rebuild) and 4.2.2 (4.2.1 rebuild) have adhoc signatures. I do not know yet how he's going to proceed.

@p-linnane
Copy link
Member

Thank you so much @i0ntempest 🙏

@i0ntempest
Copy link
Contributor Author

Two weeks without any response. Opened an issue instead.

@i0ntempest
Copy link
Contributor Author

We got a response. Upstream dev said:

  1. No plans for now for adding dev certificate in future versions
  2. Files are kept for compatibility reasons. We may just use V2rayU-64.dmg which is universal despite the name.
  3. 4.2 should be out of beta this week
  4. Don't revert to 3.8, there might be bugs

I've told him that removing the certificate will result in the cask being deprecated/removed (I believe we added this audit for cask upgrades not long ago). Let's see what he says about that.

@p-linnane
Copy link
Member

Thanks for the follow up. Let's wait for 4.2 to be released this week, and then we can update and merge this.

@p-linnane p-linnane added the upstream Issue which needs to be resolved by the upstream project. label Jul 24, 2024
@p-linnane p-linnane mentioned this pull request Jul 28, 2024
@p-linnane
Copy link
Member

v4.2.5 is now live and marked as the latest release. I've opened #180909 to bump to that version and add a livecheck to not return pre-release versions anymore.

@i0ntempest i0ntempest closed this Jul 28, 2024
@i0ntempest i0ntempest deleted the bump-v2rayu-4.2.1 branch July 28, 2024 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bump-cask-pr PR was created using `brew bump-cask-pr` upstream Issue which needs to be resolved by the upstream project.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants