Fix shellcheck issues in workflows #176544
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`shellcheck` is reporting an SC2086 ("Double quote to prevent
globbing and word splitting") issue in the
`bump-unversioned-casks.yml` workflow and SC2016 ("Expressions don't
expand in single quotes, use double quotes for that") issues in the
`ci.yml` workflow.
The SC2016 issues seem to appear because the use of backticks around
the cask names (markdown syntax) can be interpreted as legacy
backticks (as used in shell code). The only way I could appease
`shellcheck` was to use double quotes and escape the backticks.
This passes `brew style` but I haven't tested it, so hopefully it
works as intended.
samford
force-pushed
the
brew-style-shellcheck-fixes
branch
from
0aa4c6c
to
d1c3034
Compare
miccal
approved these changes
Jun 12, 2024
|
Thanks @samford -- I manually ran our autobump workflow to test, and all seems fine. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.
In the following questions
<cask>is the token of the cask you're submitting.After making any changes to a cask, existing or new, verify:
brew audit --cask --online <cask>is error-free.brew style --fix <cask>reports no offenses.Additionally, if adding a new cask:
brew audit --cask --new <cask>worked successfully.HOMEBREW_NO_INSTALL_FROM_API=1 brew install --cask <cask>worked successfully.brew uninstall --cask <cask>worked successfully.shellcheckis reporting an SC2086 ("Double quote to prevent globbing and word splitting") issue in thebump-unversioned-casks.ymlworkflow and SC2016 ("Expressions don't expand in single quotes, use double quotes for that") issues in theci.ymlworkflow.The SC2016 issues seem to appear because the use of backticks around the cask names (markdown syntax) can be interpreted as legacy backticks (as used in shell code). The only way I could appease
shellcheckwas to use double quotes and escape the backticks.This passes
brew stylebut I haven't tested it, so hopefully it works as intended. Please check my work, feel free to revert if anything breaks, etc.Related to Homebrew/brew#17482