Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rerun-workflow.yml: add support for rerunning failed jobs only #175086

Merged
merged 1 commit into from
May 30, 2024
Merged

Conversation

bevanjkay
Copy link
Member

Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.

In the following questions <cask> is the token of the cask you're submitting.

After making any changes to a cask, existing or new, verify:

Additionally, if adding a new cask:

  • Named the cask according to the token reference.
  • Checked the cask was not already refused (add your cask's name to the end of the search field).
  • Checked the cask is submitted to the correct repo.
  • brew audit --cask --new <cask> worked successfully.
  • HOMEBREW_NO_INSTALL_FROM_API=1 brew install --cask <cask> worked successfully.
  • brew uninstall --cask <cask> worked successfully.

This adds the ability for ci-requeue-failed-jobs and ci-retry-failed-jobs labels to be used, that re-run only the failed jobs instead of the whole test suite. It is useful for re-running failed jobs using the label, or in the few cases where we have flaky upstream servers, it can be difficult to get all the jobs to complete with ci-retry, this enables us to only retry the jobs that failed on a schedule.

Labels have not yet been added.

Copy link
Member

@carlocab carlocab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable to me, but I wonder if we should find another way given Homebrew/brew#17378

@bevanjkay
Copy link
Member Author

Yes possibly. I just added the option to Markus' workflow upstream though 😢

@carlocab
Copy link
Member

You can always see if Markus is willing to migrate them to https://github.com/Homebrew/actions

@bevanjkay
Copy link
Member Author

@carlocab How would you feel about merging this for now, so that it's available until we find a way to replace it?

@carlocab
Copy link
Member

I'm ok with that, but I don't have ✅ (only ✔️)

@bevanjkay bevanjkay added the ready to merge PR can be merged once CI is green label May 29, 2024
@miccal miccal merged commit 42275ea into master May 30, 2024
11 checks passed
@miccal miccal deleted the rerun branch May 30, 2024 00:22
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
automerge-skip outdated ready to merge PR can be merged once CI is green
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants