Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deepl 24.4.2912025 #172196

Merged
merged 1 commit into from Apr 26, 2024
Merged

deepl 24.4.2912025 #172196

merged 1 commit into from Apr 26, 2024

Conversation

samford
Copy link
Member

@samford samford commented Apr 25, 2024

Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.

In the following questions <cask> is the token of the cask you're submitting.

After making any changes to a cask, existing or new, verify:

Additionally, if adding a new cask:

  • Named the cask according to the token reference.
  • Checked the cask was not already refused.
  • Checked the cask is submitted to the correct repo.
  • brew audit --cask --new <cask> worked successfully.
  • HOMEBREW_NO_INSTALL_FROM_API=1 brew install --cask <cask> worked successfully.
  • brew uninstall --cask <cask> worked successfully.

It was brought to my attention in #170781 (comment) that the existing livecheck block for deepl isn't returning the latest version. This PR updates the livecheck blocks to check https://appdownload.deepl.com/macos/ (an XML response) and uses a regex with the Xml strategy to match versions from relevant tar.gz/zip file paths.

This updates the cask to the latest advertised version, 24.4.2912025, and bumps the macOS requirement to Monterey (surfaced by the related audit).

The existing url for the older version doesn't work anymore, so I updated it to the current URL found in the aforementioned XML data and also updated the livecheck block accordingly.

Closes #170781.

@samford samford added the livecheck Issues or PRs related to livecheck label Apr 25, 2024
@samford
Copy link
Member Author

samford commented Apr 25, 2024

Since the newer version requires Monterey now but the older version requires Catalina, we're in a weird situation where the cask doesn't have a version for Big Sur (macOS 11) and CI predictably fails. I'm not sure how we want to handle this.

We could technically add a block for Big Sur with the last supported version and omit the livecheck block but I'm not sure if that would be wise, helpful to users, etc. That said, we'll have to do something for Big Sur but our cask maintainers may have a better idea.

@p-linnane
Copy link
Member

Probably best to just do something like:

on_big_sur :or_older do
version "1.4.15"
sha256 "26a75c3a4e95b076dcb7468e6ce9f9493675e4a9676fd267e5b32459db900077"
livecheck do
skip "Legacy version"
end
end

@samford
Copy link
Member Author

samford commented Apr 25, 2024

24.2.1798840 seems to be the highest version that supports Big Sur, so I've added an on_big_sur block for that version.

Past that, I'm not sure if there will be further 3.7 versions (they're in an old directory). The download page only advertises versions for macOS 11 (Big Sur) and 12+ (Monterey and above), so I'm not sure if we should use skip "Legacy version" in the on_catalina :or_older block as well.

Copy link
Member

@p-linnane p-linnane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @samford!

@p-linnane p-linnane merged commit 9fa0a52 into master Apr 26, 2024
15 checks passed
@p-linnane p-linnane deleted the deepl-24.4.2912025 branch April 26, 2024 00:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
livecheck Issues or PRs related to livecheck
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants