Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mplab-xc32 4.40 #172141

Merged
merged 3 commits into from May 4, 2024
Merged

mplab-xc32 4.40 #172141

merged 3 commits into from May 4, 2024

Conversation

miccal
Copy link
Member

@miccal miccal commented Apr 25, 2024

Created by brew bump


Created with brew bump-cask-pr.

@BrewTestBot BrewTestBot added bump-cask-pr PR was created using `brew bump-cask-pr` missing zap Cask is missing a zap stanza, please add one. labels Apr 25, 2024
@BrewTestBot BrewTestBot removed the missing zap Cask is missing a zap stanza, please add one. label Apr 25, 2024
@miccal
Copy link
Member Author

miccal commented Apr 25, 2024

The same error as seen in #154311 and #145808 I believe:

The current OS X version is not supported

Contents of the installbuilder.sh script for reference:

#!/bin/sh

runtimes_dir=$(cd "$(dirname "${0}")" && pwd)
os_version=`uname -r`
machine_platform=`uname -p`
machine_arch=`uname -m`
if [ "${os_version:0:1}" == "6" ];then
    executable="none"
elif [ "${machine_platform}" == "arm" ];then

  runtimes="osx-arm64 osx-x86_64"
  executable=none
  for r in ${runtimes} ; do
    if [ -f "${runtimes_dir}/${r}" ]; then
      executable=${r}
      break
    fi
  done

elif [ "${machine_platform}" == "i386" ];then
  executable=osx-x86_64
else
    executable="none"
fi

if [ "$executable" == "none" ]; then
    echo "The current OS X version is not supported"
    exit 1
fi
            
        
if [ "${1}" == --help ] || [ "`id -u 2>/dev/null`" == "0" ];then
    "`dirname \"${0}\"`/$executable" "$@"
else
    "`dirname \"${0}\"`/MPLAB XC8 C Compiler" $executable "$@"
fi
                

@krehel
Copy link
Member

krehel commented May 4, 2024

The initial install script has a hard check for x86_64 (or i386) and on ARM processors causes the check to fail.

For now, I've marked this as depends_on arch: :x86_64, but I am close to having this working on ARM by calling the installer directly. Just a couple small things to sort I think.

@miccal
Copy link
Member Author

miccal commented May 4, 2024

The initial install script has a hard check for x86_64 (or i386) and on ARM processors causes the check to fail.

For now, I've marked this as depends_on arch: :x86_64, but I am close to having this working on ARM by calling the installer directly. Just a couple small things to sort I think.

Thank you for looking into this @krehel.

@krehel krehel added ready to merge PR can be merged once CI is green and removed help wanted labels May 4, 2024
@krehel
Copy link
Member

krehel commented May 4, 2024

I think we can merge this. I'll open a separate PR for my fixes apart from the version bump. I'll also try to fit them to mplab-xc8 and mplab-xc16 as well.

@BrewTestBot BrewTestBot merged commit 7f532c6 into Homebrew:master May 4, 2024
12 checks passed
@miccal miccal deleted the bump-mplab-xc32-4.40 branch May 4, 2024 03:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bump-cask-pr PR was created using `brew bump-cask-pr` ready to merge PR can be merged once CI is green
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants