Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update themeengine.rb to a maintained fork #171842

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

SoCuul
Copy link
Contributor

@SoCuul SoCuul commented Apr 20, 2024

Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.

In the following questions <cask> is the token of the cask you're submitting.

After making any changes to a cask, existing or new, verify:

Additionally, if adding a new cask:

- [ ] Named the cask according to the token reference.
- [ ] Checked the cask was not already refused.
- [ ] Checked the cask is submitted to the correct repo.
- [ ] brew audit --cask --new <cask> worked successfully.
- [ ] HOMEBREW_NO_INSTALL_FROM_API=1 brew install --cask <cask> worked successfully.
- [ ] brew uninstall --cask <cask> worked successfully.


@razvanazamfirei
Copy link
Member

Thanks for opening this, which of the following criteria does this cask meet?

Forks must have the vendor’s name as a prefix on the cask’s filename and token. If the original software is discontinued, forks still need to follow this rule so as to not be surprising to the user. There are two exceptions which allow the fork to replace the main cask:

The original discontinued software recommends that fork.
The fork is so overwhelmingly popular that it surpasses the original and is now the de facto project when people think of the name.
For unrelated apps that share a name, the most popular one (usually the one already present) stays unprefixed. Since this can be subjective, if you disagree with a decision, open an issue and make your case to the maintainers.

@SoCuul
Copy link
Contributor Author

SoCuul commented Apr 20, 2024

I think it would fall under the The fork is so overwhelmingly popular that it surpasses the original and is now the de facto project when people think of the name case, but I'm not sure.

The original repo has more stars and forks than the fork, but it has not been maintained for over 4 years. Looking into issues people tell you to navigate to the new fork. This new fork has less stars/forks but is a version of this software that is actively maintained and used by individuals.

@SMillerDev
Copy link
Member

Let's add it with a vendor name, and we can direct people to consider that from the old cask

@SoCuul
Copy link
Contributor Author

SoCuul commented Apr 21, 2024

Let's add it with a vendor name, and we can direct people to consider that from the old cask

I was under the assumption that discontinued casks were not allowed to exist on the repo. Did I misread the docs?

@SMillerDev
Copy link
Member

I was under the assumption that discontinued casks were not allowed to exist on the repo. Did I misread the docs?

If it's actively discontinued, yes. If it's not maintained actively... we can deprecate it.

We also don't want to install a version of software people were not expecting, so we should only replace a cask source if it is abundantly clear that nobody could possibly want the original source.

@SoCuul
Copy link
Contributor Author

SoCuul commented Apr 21, 2024

If it's actively discontinued, yes. If it's not maintained actively... we can deprecate it.

The last release was 6 years ago, and the last commit was over 4 years ago.

@SMillerDev
Copy link
Member

The last release was 6 years ago, and the last commit was over 4 years ago.

And yet, it is not explicitly discontinued so deprecating as :unmaintained is the clearest signal to users of the status of it.

@SoCuul
Copy link
Contributor Author

SoCuul commented Apr 28, 2024

The last release was 6 years ago, and the last commit was over 4 years ago.

And yet, it is not explicitly discontinued so deprecating as :unmaintained is the clearest signal to users of the status of it.

Sorry for the late reply! I see what you're saying, sounds good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants