Skip to content
This repository has been archived by the owner on May 2, 2024. It is now read-only.

propresenter-beta: update livecheck #12194

Merged
merged 1 commit into from Oct 13, 2021

Conversation

bevanjkay
Copy link
Member

No description provided.

@bevanjkay
Copy link
Member Author

@samford I was trying out the new option for referencing casks/formula in a livecheck block. We may need to wait to use this feature across our cask taps as it looks like CI doesn't have the main cask repo tapped for the audit checks.

There is an issue open and plans to migrate homebrew-cask-versions to the homebrew-cask repo which would negate this anyway.

@samford
Copy link
Member

samford commented Oct 13, 2021

Per our discussion in the PR that introduced this part of the livecheck DSL, I made sure to document this in the related section of the brew livecheck documentation:

The referenced formula/cask should be in the same tap, as a reference to a formula/cask from another tap will generate an error if the user doesn鈥檛 already have it tapped.

I can see how using this feature makes sense for alternative casks like this one (where there are also new versions to check). It seems like it's technically possible to modify this repository's ci.yml GitHub Actions workflow to also tap homebrew/cask but I'm not familiar enough with the cask side of things to say whether this is appropriate/worthwhile.

However, though this may be possible on CI, I would prefer to avoid using this livecheck feature across taps. Anyone who happens to have homebrew/cask-versions tapped but not homebrew/cask (unlikely but seemingly possible?) would predictably get an error when running brew livecheck on this. While this change would ease maintainability of this livecheck block, it could break an otherwise-working check for some users.

From my perspective, this is something to revisit if/when these casks are merged into homebrew/cask but I would leave this as-is for now.

@bevanjkay
Copy link
Member Author

However, though this may be possible on CI, I would prefer to avoid using this livecheck feature across taps. Anyone who happens to have homebrew/cask-versions tapped but not homebrew/cask (unlikely but seemingly possible?)

Yes, that totally makes sense. I had wrongly assumed that the main homebrew-cask tap would always be present. Thanks @samford

@miccal miccal merged commit 1a138ef into Homebrew:master Oct 13, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants