Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--quiet silences "Using xyz" in brew bundle install #1346

Merged
merged 1 commit into from Apr 23, 2024

Conversation

rrotter
Copy link
Contributor

@rrotter rrotter commented Apr 23, 2024

This is intended to resolve #1202. Only addresses the brew bundle install subcommand because I don't see any other subcommands where --quiet makes sense. I don't think it's desirable to suppress other non-error output (e.g. "Homebrew Bundle complete!..." and "Downloading https://formulae.brew.sh/api/cask.jws.json") unless we added a -qq option, which would require more far reaching changes to how arg parsing works (--quiet is parsed by code in homebrew/brew, not this repo).

Fixes #1202

lib/bundle/installer.rb Show resolved Hide resolved
@MikeMcQuaid
Copy link
Member

Thanks so much for your first contribution! Without people like you submitting PRs we couldn't run this project. You rock, @rrotter!

@MikeMcQuaid MikeMcQuaid merged commit b43e551 into Homebrew:master Apr 23, 2024
2 checks passed
@rrotter rrotter deleted the be_quiet branch April 23, 2024 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request: Respect --quiet/-q cli flag
3 participants