fix(brew search): Improve hints for apps migrated within the same tap#21881
Open
yermulnik wants to merge 2 commits intoHomebrew:mainfrom
Open
fix(brew search): Improve hints for apps migrated within the same tap#21881yermulnik wants to merge 2 commits intoHomebrew:mainfrom
yermulnik wants to merge 2 commits intoHomebrew:mainfrom
Conversation
3 tasks
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates Homebrew’s missing-formula hinting to produce more accurate guidance when a formula has been migrated to a cask within the same tap, improving the brew search/missing formula messaging for third-party taps using tap_migrations.json.
Changes:
- Add a “same tap” migration path that changes the message and avoids suggesting
brew tap …when the migration stays within the same tap. - Adjust the suggested install command to use
brew install --caskfor same-tap formula→cask migrations. - Simplify/reshape the output formatting to better fit the new messaging.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
MikeMcQuaid
reviewed
Apr 1, 2026
Member
MikeMcQuaid
left a comment
There was a problem hiding this comment.
Thanks for the PR @yermulnik! This logic all looks good and makes sense to me and the wording improvements are 😍.
Just requesting @cho-m give it another look as I'm always a bit twitchy about this sort of logic.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
brew lgtm(style, typechecking and tests) with your changes locally?Since the #21224 was merged and released via https://github.com/Homebrew/brew/releases/tag/5.0.6, the tap migrations within the same tap are working for the third-party taps. However the same wasn't implemented for
brew searchwhich still outputs odd hints for such apps that were migrated from a formula to a cask within the same tap. E.g.:This is a follow up to #21207 and attempts to provide a more meaningful and correct hints for apps migrated within the same tap.
Cc @MikeMcQuaid