Skip to content

Conversation

@cho-m
Copy link
Member

@cho-m cho-m commented Dec 5, 2025

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew lgtm (style, typechecking and tests) with your changes locally?

The code handling predefined options was removed back in 74fb058 so these are no-ops given BuildOptions expects with- or without- prefixed option names.

Also remove checks for ENV.universal_binary as that was removed in d733512

Copilot AI review requested due to automatic review settings December 5, 2025 19:58
The code handling predefined options was removed back in
74fb058 so these are no-ops given
BuildOptions expects `with-` or `without-` prefixed option names.

Also remove checks for `ENV.universal_binary` as that was removed in
d733512
@cho-m cho-m force-pushed the option-symbols-cleanup branch from 33428ee to a33649d Compare December 5, 2025 20:02
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request removes deprecated predefined options (:cxx11 and :universal) and related code that became no-ops after the BuildOptions refactoring. The PR cleans up technical debt by deprecating symbol-based option syntax in favor of string-based options with with-/without- prefixes.

  • Removes the PREDEFINED_OPTIONS constant and special handling for :cxx11 and :universal options
  • Adds graceful deprecation for any symbol-based option usage via odeprecated
  • Removes RuboCop checks for build.universal? and ENV.universal_binary which were already removed from the codebase
  • Updates tests to reflect the removal of special-cased option handling

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
Library/Homebrew/software_spec.rb Removes PREDEFINED_OPTIONS constant and simplifies option method to only accept String names
Library/Homebrew/formula.rb Updates documentation to remove :universal example and adds deprecation handling for symbol-based options
Library/Homebrew/rubocops/options.rb Removes special cases for "cxx11" and "universal" options from RuboCop checks
Library/Homebrew/rubocops/lines.rb Removes deprecated checks for build.universal? and ENV.universal_binary
Library/Homebrew/test/software_spec_spec.rb Removes test for special-cased cxx11 option handling
Library/Homebrew/test/rubocops/text/miscellaneous_spec.rb Removes tests for deprecated universal binary checks
Library/Homebrew/test/rubocops/options_spec.rb Removes tests for deprecated 32-bit and universal options, cleans up test case

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants