Enable recursive typechecking in specs

[dduugg]

• Have you followed the guidelines in our Contributing document?
• Have you checked to ensure there aren't other open Pull Requests for the same change?
• Have you added an explanation of what your changes do and why you'd like us to include them?
• Have you written new tests for your changes? Here's an example.
• Have you successfully run brew style with your changes locally?
• Have you successfully run brew typecheck with your changes locally?
• Have you successfully run brew tests with your changes locally?

---

Just prototyping, curious what happens if we enable recursive typechecking in specs. (Feel free to comment if you think this is or isn't a valuable route to pursue further.)

This is done via 🐒-patching due to sorbet/sorbet#3800

[MikeMcQuaid]

This is a great idea!

[MikeMcQuaid]

I'm good to land this if/when you are.

[dduugg]

I'm good to land this if/when you are.

Sounds good, this still needs some work though (I want to limit this to specs for now, it's currently turned on globally for my own convenience. The commits also need to be squashed. I want to make a final pass that the updates make sense (I made a couple small changes last night), and elaborate in comments/todos where I've undertaken some light refactoring.)

[dduugg]

I confirmed in the sorbet slack that this is the best approach currently available. Opening for re-review for anyone who wants to take a look, otherwise i'll merge within the next day or so.

[MikeMcQuaid]

Thanks @dduugg, great work here!

[fxcoudert]

This may have caused this bug, reported by multiple users (including me): #20703

$ brew up
==> Updating Homebrew...
Updated 1 tap (homebrew/core).
Error: Return value: Expected type {A: T::Array[String], AC: T::Array[String], D: T::Array[String], DC: T::Array[String], M: T::Array[String], MC: T::Array[String], R: T::Array[[String, String]], RC: T::Array[[String, String]]}, got type {M: Array}
Caller: /opt/homebrew/Library/Homebrew/cmd/update-report.rb:635
Definition: /opt/homebrew/Library/Homebrew/cmd/update-report.rb:479 (Reporter#report)

[MikeMcQuaid]

Reverted in #20705 but re-applied with a fix in #20705