caveats: suggest setting CMAKE_PREFIX_PATH when appropriate
#20606
+11
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Inspired by Homebrew/homebrew-core#235513. It doesn't quite fix that issue, because `libomp` does not ship CMake config files, but this would probably still be useful for keg-only formulae that do ship CMake config files. While we're here, let's replace the `pkg-config` references with the now-canonical name `pkgconf`.
ZhongRuoyu
approved these changes
Aug 29, 2025
Comment on lines
-98
to
+102
| if which("pkg-config", ORIGINAL_PATHS) && | ||
| if which("pkgconf", ORIGINAL_PATHS) && | ||
| ((formula.lib/"pkgconfig").directory? || (formula.share/"pkgconfig").directory?) | ||
| s << <<~EOS | ||
|
|
||
| For pkg-config to find #{formula.name} you may need to set: | ||
| For pkgconf to find #{formula.name} you may need to set: |
There was a problem hiding this comment.
Do we want to keep pkg-config here, and instead rely on pkgconf providing a pkg-config symlink, so that this continues to work for those with the old pkg-config? Don't feel strongly though!
There was a problem hiding this comment.
Or I guess we could check for both
MikeMcQuaid
approved these changes
Aug 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew stylewith your changes locally?brew typecheckwith your changes locally?brew testswith your changes locally?Inspired by Homebrew/homebrew-core#235513.
It doesn't quite fix that issue, because
libompdoes not ship CMakeconfig files, but this would probably still be useful for keg-only
formulae that do ship CMake config files.
While we're here, let's replace the
pkg-configreferences with thenow-canonical name
pkgconf.