cask/info: send missing args after removing openstruct

[apainintheneck]

• Have you followed the guidelines in our Contributing document?
• Have you checked to ensure there aren't other open Pull Requests for the same change?
• Have you added an explanation of what your changes do and why you'd like us to include them?
• Have you written new tests for your changes? Here's an example.
• Have you successfully run brew style with your changes locally?
• Have you successfully run brew typecheck with your changes locally?
• Have you successfully run brew tests with your changes locally?

---

This should fix #18915 and is an attempt to fix forward so we don't have to rollback #18847 since this seems like a minor issue.

This seems like it was a bug before the recent change to remove OpenStruct from Homebrew::CLI::Args but it was failing silently before. Now we pass the args to the Cask::Info.info method so that when they eventually reach the Utils::Analytics.output_analytics method they are present as expected.

Note that this error requires HOMEBREW_NO_ANALYTICS to not be set and --verbose to be passed along with brew info CASK.

Example error fragment:

$ set -e HOMEBREW_NO_ANALYTICS
$ brew info iterm2 --cask --verbose
==> iterm2: 3.5.10 (auto_updates)
https://iterm2.com/
Installed
/usr/local/Caskroom/iterm2/3.5.4 (91.7MB)
From: https://github.com/Homebrew/homebrew-cask/blob/HEAD/Casks/i/iterm2.rb
==> Name
iTerm2
==> Description
Terminal emulator as alternative to Apple's Terminal app
==> Artifacts
iTerm.app (App)
Error: undefined method `analytics?' for an instance of Homebrew::CLI::Args
/usr/local/Homebrew/Library/Homebrew/utils/analytics.rb:248:in `output_analytics'
/usr/local/Homebrew/Library/Homebrew/utils/analytics.rb:342:in `cask_output'
/usr/local/Homebrew/Library/Homebrew/cask/info.rb:39:in `info'
...

Expected output:

$ brew info iterm2 --cask --verbose
==> iterm2: 3.5.10 (auto_updates)
https://iterm2.com/
Installed
/usr/local/Caskroom/iterm2/3.5.4 (91.7MB)
From: https://github.com/Homebrew/homebrew-cask/blob/HEAD/Casks/i/iterm2.rb
==> Name
iTerm2
==> Description
Terminal emulator as alternative to Apple's Terminal app
==> Artifacts
iTerm.app (App)
==> Analytics
==> install (30 days)
Index | Name (with options)                                                                          |  Count |  Percent
-----:|----------------------------------------------------------------------------------------------|-------:|--------:
1     | iterm2                                                                                       | 27,977 |  100.00%
==> install (90 days)
Index | Name (with options)                                                                          |  Count |  Percent
-----:|----------------------------------------------------------------------------------------------|-------:|--------:
1     | iterm2                                                                                       | 75,134 |  100.00%
==> install (365 days)
Index | Name (with options)                                                                         |   Count |  Percent
-----:|---------------------------------------------------------------------------------------------|--------:|--------:
1     | iterm2                                                                                      | 287,267 |  100.00%

[apainintheneck]

I believe this was an existing bug that only came to light because of recent changes. It seems like by creating a new instance of the CLI args here that args.analytics? would always be falsey later on which doesn't seem to be the desired behavior. Now when the --analytics flag is set it will get passed to Utils::Analytics.cask_output the same way it already gets passed to Utils::Analytics.formula_output.

[dduugg]

Nice work! We might want to add some guardrails around where/how Args can be instantiated 🤔

[apainintheneck]

IMO it's probably not necessary unless it's really simple to implement since I doubt that we'll ever run into the same problem again.

[MikeMcQuaid]

Thanks @apainintheneck!