Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shims/mac/super: add pkgconf symlink #18823

Merged
merged 1 commit into from
Dec 19, 2024
Merged

shims/mac/super: add pkgconf symlink #18823

merged 1 commit into from
Dec 19, 2024

Conversation

cho-m
Copy link
Member

@cho-m cho-m commented Nov 25, 2024

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Since we switched to pkgconf, it is possible that a build tool may use it before pkg-config so make sure both shims are available.


Not specifically likely, but just in case. Also handles running pkgconf directly in formula.

May want to update pkg-config shim later on (e.g. so actual executable is found on shim-excluded superenv's PATH rather than hardcoded).

Or perhaps seeing if pkgconf is willing to support the environment variables overrides as those are less intrusive in build than shim.

Since we switched to `pkgconf`, it is possible that a build tool may use
it before `pkg-config` so make sure both shims are available.
@MikeMcQuaid
Copy link
Member

Thanks @cho-m! Fine to merge as-is but feels like we should probably make pkg-config point to pkgconf eventually.

@cho-m
Copy link
Member Author

cho-m commented Nov 26, 2024

Fine to merge as-is but feels like we should probably make pkg-config point to pkgconf eventually.

I can do this in a follow up as I plan to rewrite the pkg-config shim as I want it to behave more like our other shims.

Copy link

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@github-actions github-actions bot added the stale No recent activity label Dec 18, 2024
@cho-m cho-m removed the stale No recent activity label Dec 19, 2024
@cho-m cho-m added this pull request to the merge queue Dec 19, 2024
Merged via the queue into master with commit af9d13f Dec 19, 2024
28 checks passed
@cho-m cho-m deleted the pkgconf-shim branch December 19, 2024 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants