Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

api/analytics: use typed: strict #18088

Merged
merged 2 commits into from
Aug 20, 2024
Merged

api/analytics: use typed: strict #18088

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
85dfe25
api/analytics: use `typed: strict`
p-linnane Aug 19, 2024
683a8aa
Update analytics.rb
p-linnane Aug 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Library/Homebrew/api/analytics.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# typed: true # rubocop:todo Sorbet/StrictSigil
# typed: strict
# frozen_string_literal: true

module Homebrew
Expand All @@ -12,7 +12,7 @@ def analytics_api_path
end
alias generic_analytics_api_path analytics_api_path

sig { params(category: String, days: T.any(Integer, String)).returns(Hash) }
sig { params(category: String, days: T.any(Integer, String)).returns(T::Hash[String, T.untyped]) }
def fetch(category, days)
Homebrew::API.fetch "#{analytics_api_path}/#{category}/#{days}d.json"
end
Expand Down