Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Encourage Sorbet # typed: strict in new code #18018

Closed
wants to merge 1 commit into from

Commits on Aug 11, 2024

  1. ci: Encourage Sorbet "# typed: strict" in new code

    - Let's make Sorbet strict mode the default for new files, where
      possible.
    - This adds a new GitHub Actions step in the test job, _before_
      typechecking, which ensures that new Ruby files are Sorbet strictly
      typed.
    
    Tested with:
    
    ```shell
    [ci-check-new-files-srb-strict e9dc524ef6] test new files
     Date: Sun Aug 11 23:39:50 2024 +0100
     4 files changed, 5 insertions(+)
     create mode 100644 Library/Homebrew/bad.rb
     create mode 100644 Library/Homebrew/forgot.rb
     create mode 100644 Library/Homebrew/good.rb
     create mode 100644 Library/Homebrew/should_not_care.yml
    
    $ bash sorbet_sigils.sh
    Add the Sorbet strict sigil (# typed: strict) to Library/Homebrew/bad.rb.
    Add the Sorbet strict sigil (# typed: strict) to Library/Homebrew/forgot.rb.
    ```
    issyl0 committed Aug 11, 2024
    Configuration menu
    Copy the full SHA
    c5d2a42 View commit details
    Browse the repository at this point in the history