Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

language/*: only check required deps in detected_*_shebang #17993

Merged
merged 1 commit into from
Aug 9, 2024

Conversation

MikeMcQuaid
Copy link
Member

Otherwise, we rewrite this even when we have a e.g. build or test dependency on NodeJS.

See context in:
Homebrew/homebrew-core#176257 (comment)

Otherwise, we rewrite this even when we have a e.g. build or test
dependency on NodeJS.

See context in:
Homebrew/homebrew-core#176257 (comment)
Copy link
Member

@carlocab carlocab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Mike!

carlocab added a commit to Homebrew/homebrew-core that referenced this pull request Aug 9, 2024
This will not be needed after Homebrew/brew#17993.
carlocab added a commit to Homebrew/homebrew-core that referenced this pull request Aug 9, 2024
This will not be needed after Homebrew/brew#17993.
carlocab added a commit to Homebrew/homebrew-core that referenced this pull request Aug 9, 2024
This will not be needed after Homebrew/brew#17993.
@MikeMcQuaid MikeMcQuaid merged commit 2a32d39 into master Aug 9, 2024
24 checks passed
@MikeMcQuaid MikeMcQuaid deleted the language_deps_required branch August 9, 2024 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants