Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

formula: remove std_npm_args from system's pretty_args #17865

Merged
merged 1 commit into from
Jul 26, 2024

Conversation

branchvincent
Copy link
Member

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Fixes #17774 (comment)

std_npm_args unfortunately has a side-effect of requiring a package.json in the current directory:

output = Utils.popen_read("npm", "pack", "--ignore-scripts")

@Bo98 Bo98 enabled auto-merge July 26, 2024 00:15
@branchvincent branchvincent mentioned this pull request Jul 26, 2024
7 tasks
@Bo98 Bo98 merged commit 1f198e6 into Homebrew:master Jul 26, 2024
24 checks passed
@branchvincent branchvincent deleted the npm_side_effect branch July 26, 2024 00:25
@MikeMcQuaid
Copy link
Member

This seems like a good temporary workaround @branchvincent but I'd like to see this re-added and the issue resolved another way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants